From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [RFC PATCH] Makefile: new prove target for running the tests with TAP
Date: Thu, 14 Oct 2010 11:27:57 -0500 [thread overview]
Message-ID: <20101014162757.GC16500@burratino> (raw)
In-Reply-To: <5c46df95f93b56aa2fce56c7efe7b2be80642c8b.1287045908.git.git@drmicha.warpmail.net>
Michael J Gruber wrote:
> Introduce a new make target "prove" which runs the tests via "prove"
I like it. :)
I've been using
prove -j2 --shuffle t[0-9]*.sh
and would be happier to be able to dump GIT_PROVE_OPTS="-j2 --shuffle"
in my config.mak and just run "make prove" instead of that unwieldly
glob.
> RFC also because of lack of doc, and:
>
> Currently, one can do
>
> make -C t t6010-merge-base.sh
>
> or even
>
> make -C t t601*
>
> which is cool but undocumented. If we want this with prove it requires more
> effort
Doesn't "prove t601*" work well for that use case already?
> --- a/t/Makefile
> +++ b/t/Makefile
[...]
> +prove: pre-clean
> + @echo "*** prove ***"; GIT_CONFIG=.git/config $(PROVE) --exec '$(SHELL_PATH_SQ)' $(GIT_PROVE_OPTS) $(T) :: $(GIT_TEST_OPTS)
> + $(MAKE) clean
> +
> $(T):
> @echo "*** $@ ***"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)
Not about this patch, but is that GIT_CONFIG setting needed? I would have
guessed rather that test-lib.sh would unset GIT_CONFIG as soon as possible.
next prev parent reply other threads:[~2010-10-14 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 8:53 [RFC PATCH] Makefile: new prove target for running the tests with TAP Michael J Gruber
2010-10-14 9:05 ` Ævar Arnfjörð Bjarmason
2010-10-14 9:21 ` Michael J Gruber
2010-10-14 9:33 ` Ævar Arnfjörð Bjarmason
2010-10-14 16:27 ` Jonathan Nieder [this message]
2010-10-14 17:23 ` Jeff King
2010-10-27 0:18 ` Junio C Hamano
2010-10-27 4:57 ` Jeff King
2010-10-27 11:00 ` Ævar Arnfjörð Bjarmason
2010-10-29 13:19 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014162757.GC16500@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.