From: Jarod Wilson <jarod@redhat.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
"Jarod Wilson" <jarod@wilsonet.com>,
"David Härdeman" <david@hardeman.nu>,
mchehab@infradead.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [2/8] IR: make sure we register the input device when it is safe to do so.
Date: Thu, 14 Oct 2010 15:30:48 -0400 [thread overview]
Message-ID: <20101014193048.GA4244@redhat.com> (raw)
In-Reply-To: <1283808373-27876-3-git-send-email-maximlevitsky@gmail.com>
On Mon, Sep 06, 2010 at 09:26:07PM -0000, Maxim Levitsky wrote:
> As soon as input device is registered, it might be accessed (and it is)
> This can trigger a hardware interrupt that can access
> not yet initialized ir->raw, (by sending a sample)
>
> This can be reproduced by holding down a remote button and reloading the module.
> And this always crashes the systems where hardware decides to send an interrupt
> right at the moment it is enabled.
>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Another one I thought I'd acked, but I don't see the ack in patchwork, so
it may have been from an earlier/superseded version...
Finally got my head wrapped around this one too, and I do see the
problem, and this fix looks good to me.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2010-10-14 19:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 21:26 [PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver Maxim Levitsky
2010-09-06 21:26 ` [PATCH 1/8] IR: plug races in IR raw thread Maxim Levitsky
2010-09-09 4:13 ` Jarod Wilson
2010-10-14 19:29 ` [1/8] " Jarod Wilson
2010-09-06 21:26 ` [PATCH 2/8] IR: make sure we register the input device when it is safe to do so Maxim Levitsky
2010-09-09 4:19 ` Jarod Wilson
2010-10-14 19:30 ` Jarod Wilson [this message]
2010-09-06 21:26 ` [PATCH 3/8] IR: fix duty cycle capability Maxim Levitsky
2010-09-08 14:44 ` Jarod Wilson
2010-09-06 21:26 ` [PATCH 4/8] IR: fix keys beeing stuck down forever Maxim Levitsky
2010-09-08 14:47 ` Jarod Wilson
2010-09-06 21:26 ` [PATCH 5/8] IR: extend MCE keymap Maxim Levitsky
2010-09-08 14:47 ` Jarod Wilson
2010-09-08 14:47 ` Jarod Wilson
2010-09-10 0:40 ` Maxim Levitsky
2010-09-10 1:37 ` Jarod Wilson
2010-09-10 1:37 ` Jarod Wilson
2010-09-10 8:27 ` David Härdeman
2010-09-10 13:18 ` Jarod Wilson
2010-09-10 13:18 ` Jarod Wilson
2010-09-10 8:40 ` Maxim Levitsky
2010-09-10 13:11 ` Jarod Wilson
2010-09-06 21:26 ` [PATCH 6/8] IR: ene_ir: updates Maxim Levitsky
2010-09-06 21:26 ` [PATCH 7/8] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-09-08 15:26 ` Jarod Wilson
2010-09-08 15:26 ` Jarod Wilson
2010-09-08 16:50 ` Andy Walls
2010-09-08 17:27 ` Jarod Wilson
2010-09-08 23:02 ` Andy Walls
2010-09-08 23:08 ` David Härdeman
2010-09-08 23:08 ` David Härdeman
2010-09-08 23:49 ` Mauro Carvalho Chehab
2010-09-08 22:42 ` Mauro Carvalho Chehab
2010-09-08 22:49 ` David Härdeman
2010-09-08 22:54 ` Mauro Carvalho Chehab
2010-10-14 21:46 ` Jarod Wilson
2010-09-06 21:26 ` [PATCH 8/8] IR: ene_ir: add support for carrier reports Maxim Levitsky
2010-09-06 21:56 ` [PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver David Härdeman
2010-09-06 21:56 ` David Härdeman
2010-09-06 22:38 ` Maxim Levitsky
2010-09-06 22:38 ` Maxim Levitsky
2010-09-08 21:54 ` Mauro Carvalho Chehab
2010-09-08 22:42 ` Jarod Wilson
2010-09-09 4:34 ` Jarod Wilson
2010-09-10 2:01 ` Jarod Wilson
2010-09-10 8:08 ` David Härdeman
2010-09-10 8:08 ` David Härdeman
2010-09-10 13:03 ` Jarod Wilson
2010-09-10 13:03 ` Jarod Wilson
2010-09-10 8:35 ` Maxim Levitsky
2010-09-10 13:21 ` Jarod Wilson
[not found] ` <1283808373-27876-1-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-14 2:36 ` Maxim Levitsky
2010-10-14 2:36 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014193048.GA4244@redhat.com \
--to=jarod@redhat.com \
--cc=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.