From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] mach-pcm037_eet: fix compile errors
Date: Fri, 15 Oct 2010 09:07:31 +0200 [thread overview]
Message-ID: <20101015070731.GF6747@pengutronix.de> (raw)
In-Reply-To: <1287097205-18595-1-git-send-email-eric@eukrea.com>
Hello,
On Fri, Oct 15, 2010 at 01:00:01AM +0200, Eric B?nard wrote:
> this patch fix the following errors :
> arch/arm/mach-mx3/mach-pcm037_eet.c:62: error: implicit declaration of function 'MXC_SPI_CS'
> arch/arm/mach-mx3/mach-pcm037_eet.c:185: error: implicit declaration of function 'imx35_add_spi_imx0'
>
> from the Kconfig pcm037 is i.MX31 based and not i.MX35 so replace
> imx35_add_spi_imx0 by imx31_add_spi_imx0
Grrr, sorry.
Can you please add a reference to
a4dc013570e08ec4947b10fa78080da767b30527 in the commit log?
>
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> ---
> arch/arm/mach-mx3/mach-pcm037_eet.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mx3/mach-pcm037_eet.c b/arch/arm/mach-mx3/mach-pcm037_eet.c
> index c8b9821..2ee5d09 100644
> --- a/arch/arm/mach-mx3/mach-pcm037_eet.c
> +++ b/arch/arm/mach-mx3/mach-pcm037_eet.c
> @@ -14,11 +14,13 @@
>
> #include <mach/common.h>
> #include <mach/iomux-mx3.h>
> +#include <mach/spi.h>
This is not needed as devices-imx31.h includes devices-common.h which in
turn includes mach/spi.h.
>
> #include <asm/mach-types.h>
>
> #include "pcm037.h"
> #include "devices.h"
> +#include "devices-imx31.h"
>
> static unsigned int pcm037_eet_pins[] = {
> /* Reserve and hardwire GPIO 57 high - S6E63D6 chipselect */
> @@ -181,7 +183,7 @@ static int eet_init_devices(void)
> /* SPI */
> spi_register_board_info(pcm037_spi_dev, ARRAY_SIZE(pcm037_spi_dev));
> #if defined(CONFIG_SPI_IMX) || defined(CONFIG_SPI_IMX_MODULE)
> - imx35_add_spi_imx0(&pcm037_spi1_pdata);
> + imx31_add_spi_imx0(&pcm037_spi1_pdata);
> #endif
>
> platform_device_register(&pcm037_gpio_keys_device);
Other than that the change is OK.
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-10-15 7:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 23:00 [PATCH 1/5] mach-pcm037_eet: fix compile errors Eric Bénard
2010-10-14 23:00 ` [PATCH 2/5] mx25: add defconfig Eric Bénard
2010-10-15 7:22 ` Uwe Kleine-König
2010-10-15 8:19 ` Eric Bénard
2010-10-14 23:00 ` [PATCH 3/5] mx27: update defconfig Eric Bénard
2010-10-15 7:27 ` Uwe Kleine-König
2010-10-14 23:00 ` [PATCH 4/5] mx3: " Eric Bénard
2010-10-14 23:00 ` [PATCH 5/5] mx51: " Eric Bénard
2010-10-15 7:07 ` Uwe Kleine-König [this message]
2010-10-15 10:15 ` [PATCH v2 1/5] mach-pcm037_eet: fix compile errors Eric Bénard
2010-10-15 10:15 ` [PATCH v2 2/5] mx25: add defconfig Eric Bénard
2010-10-16 18:33 ` Baruch Siach
2010-10-15 10:15 ` [PATCH v2 3/5] mx27: update defconfig Eric Bénard
2010-10-15 10:15 ` [PATCH v2 4/5] mx3: " Eric Bénard
2010-10-15 10:15 ` [PATCH v2 5/5] mx51: " Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015070731.GF6747@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.