From: Andi Kleen <andi@firstfloor.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
jengelh@medozas.de, davem@davemloft.net, andi@firstfloor.org
Subject: Re: [PATCH] types.h: define __aligned_u64 and expose to userspace
Date: Fri, 15 Oct 2010 10:43:11 +0200 [thread overview]
Message-ID: <20101015084311.GA25620@basil.fritz.box> (raw)
In-Reply-To: <20101015042455.12772.27482.stgit@paris.rdu.redhat.com>
On Fri, Oct 15, 2010 at 12:24:55AM -0400, Eric Paris wrote:
> We currently have a kernel internal type called aligned_u64 which aligns
> __u64's on 8 bytes boundaries even on systems which would normally align
> them on 4 byte boundaries. This patch creates a new type __aligned_u64
> which does the same thing but which is exposed to userspace rather than
> being kernel internal.
>
> Based-on-patch-by: Andreas Gruenbacher <agruen@suse.de>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Andi Kleen <ak@linux.intel.com>
but only if you:
> +/* this is a special 64bit data type that is 8-byte aligned */
Expand this comment a bit that that using this type as a
replacement for u64 is recommended
for any user visible 64bit value in a structure and that it
avoids problem with the compat layer on x86-64.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-10-15 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 4:24 [PATCH] types.h: define __aligned_u64 and expose to userspace Eric Paris
2010-10-15 8:43 ` Andi Kleen [this message]
2010-10-15 9:03 ` Andrew Morton
2010-10-15 8:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015084311.GA25620@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.