From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 22/22] bitops: remove minix bitops from asm/bitops.h Date: Fri, 15 Oct 2010 12:53:15 +0200 Message-ID: <201010151253.15653.arnd@arndb.de> References: <1287135981-17604-1-git-send-email-akinobu.mita@gmail.com> <1287135981-17604-23-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.171]:61025 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755116Ab0JOKxV (ORCPT ); Fri, 15 Oct 2010 06:53:21 -0400 In-Reply-To: <1287135981-17604-23-git-send-email-akinobu.mita@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Christoph Hellwig , Andrew Morton On Friday 15 October 2010, Akinobu Mita wrote: > minix bit operations are only used by minix filesystem and useless > by other modules. Right. > This provides new config option CONFIG_MINIX_FS_LITTLE_ENDIAN and > CONFIG_MINIX_FS_NATIVE_ENDIAN that each architecture selects one of which. > Then we can remove minix bit operations from asm/bitops.h from all > architectures by making them minix filesystem local macros. I would say that any architecture that defines minix bitops as little-endian is broken and we should not even need the #define. You have defined these as "native endian": always LE: alpha, blackfin, ia64, score, tile, x86 always BE: h8300, microblaze, s390, sparc configurable: m32r, mips, sh, xtensa The only ones among these that possibly ever cared about mounting minix file systems on a big-endian kernel are really old sparc and mips systems, everyone else probably never noticed their mistake. I'd say let's define the minix bitops as always LE and be done with it. Arnd