From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] Check for flex and bison
Date: Fri, 15 Oct 2010 14:10:44 +0000 [thread overview]
Message-ID: <20101015141044.GA25978@ericsson.com> (raw)
In-Reply-To: <20101015153005.2d3fcac8@endymion.delvare>
On Fri, Oct 15, 2010 at 09:30:05AM -0400, Jean Delvare wrote:
> Hi all,
>
> I sometimes help people on IRC who have trouble building lm-sensors
> from source, and the most frequent problem is that they don't have flex
> and bison installed. The error message they get is all but explicit.
> While I agree they should have read the documentation which _does_
> explain that flex and bison are required, I think we could still be a
> little more helpful with a proper error message.
>
> Is there any objection to the following patch? I hope "which" is
> portable enough.
>
> Index: Makefile
> =================================> --- Makefile (révision 5865)
> +++ Makefile (copie de travail)
> @@ -267,6 +267,10 @@
>
> # Flex and Bison
> %c: %y
> + @if ! which $(BISON) 2> /dev/null ; then \
> + echo "Please install $(BISON), then run \"make clean\" and try again" ; \
> + false ; \
> + fi
> $(BISON) -p sensors_yy -d $< -o $@
>
> ifeq ($(DEBUG),1)
> @@ -276,4 +280,8 @@
> endif
>
> %.c: %.l
> + @if ! which $(FLEX) 2> /dev/null ; then \
> + echo "Please install $(FLEX), then run \"make clean\" and try again" ; \
> + false ; \
> + fi
> $(FLEX) $(FLEX_FLAGS) $< > $@
>
Looks good (and makes sense) to me.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2010-10-15 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 13:30 [lm-sensors] [PATCH] Check for flex and bison Jean Delvare
2010-10-15 14:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015141044.GA25978@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.