From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 22/22] bitops: remove minix bitops from asm/bitops.h Date: Fri, 15 Oct 2010 22:15:20 +0200 Message-ID: <201010152215.20400.arnd@arndb.de> References: <1287135981-17604-1-git-send-email-akinobu.mita@gmail.com> <201010151253.15653.arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Mike Frysinger Cc: Akinobu Mita , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Christoph Hellwig , Andrew Morton List-Id: linux-arch.vger.kernel.org On Friday 15 October 2010 20:53:16 Mike Frysinger wrote: > > You have defined these as "native endian": > > > > always LE: > > alpha, blackfin, ia64, score, tile, x86 > > > > always BE: > > h8300, microblaze, s390, sparc > > > > configurable: > > m32r, mips, sh, xtensa > > > > The only ones among these that possibly ever cared about mounting minix > > file systems on a big-endian kernel are really old sparc and mips systems, > > everyone else probably never noticed their mistake. > > > > I'd say let's define the minix bitops as always LE and be done with it. > > or at least make it so that this is the default, and you only have to > update Kconfig if you need to deviate from the default. i dont like > having to add this minix option to every single arch Kconfig. Yes, that would also work if we find a compelling reason to keep it that way. You can actually keep it private to fs/minix/Kconfig by writing it as config MINIX_FS_NATIVE_ENDIAN def_bool y depends on H8300 || M32R || MICROBLAZE || MIPS || S390 || SUPERH || SPARC || XTENSA We normally use select for arch specific options, but in this case I think I would prefer the single option since we know we don't want new architectures to do it too. Arnd