From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
takata@linux-m32r.org, linux-m32r@ml.linux-m32r.org
Subject: Re: [PATCH 2/4] m32r: get_user takes an lvalue, not a pointer
Date: Sat, 16 Oct 2010 02:44:30 +0100 [thread overview]
Message-ID: <20101016014430.GS19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20101016011709.GT8332@bombadil.infradead.org>
On Fri, Oct 15, 2010 at 09:17:09PM -0400, Kyle McMartin wrote:
> static int prev_insn(struct pt_regs *regs)
> {
> u16 inst;
> - if (get_user(&inst, (u16 __user *)(regs->bpc - 2)))
> + if (get_user(inst, (u16 __user *)(regs->bpc - 2)))
Ouch... ACKed, my fuckup.
next prev parent reply other threads:[~2010-10-16 1:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 1:09 [PATCH 0/4] m32r: build fixes Kyle McMartin
2010-10-16 1:16 ` [PATCH 1/4] m32r: restore _BLOCKABLE Kyle McMartin
2010-10-16 1:41 ` Al Viro
2010-10-16 1:17 ` [PATCH 2/4] m32r: get_user takes an lvalue, not a pointer Kyle McMartin
2010-10-16 1:44 ` Al Viro [this message]
2010-10-16 1:17 ` [PATCH 3/4] m32r: add kernel/.gitignore and ignore vmlinux.lds Kyle McMartin
2010-10-16 1:17 ` [PATCH 4/4] m32r: test __LITTLE_ENDIAN__ instead of __LITTLE_ENDIAN Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016014430.GS19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=takata@linux-m32r.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.