From: Nick Piggin <npiggin@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/18] fs: Implement lazy LRU updates for inodes.
Date: Sat, 16 Oct 2010 18:56:58 +1100 [thread overview]
Message-ID: <20101016075658.GN19147@amd> (raw)
In-Reply-To: <20101013133213.GC5263@infradead.org>
On Wed, Oct 13, 2010 at 09:32:13AM -0400, Christoph Hellwig wrote:
> > */
> > redirty_tail(inode);
> > - } else if (atomic_read(&inode->i_count)) {
> > - /*
> > - * The inode is clean, inuse
> > - */
> > - list_move(&inode->i_list, &inode_in_use);
> > } else {
> > - /*
> > - * The inode is clean, unused
> > - */
> > - list_move(&inode->i_list, &inode_unused);
> > + /* The inode is clean */
> > + list_del_init(&inode->i_list);
> > + inode_lru_list_add(inode);
>
> Just noticed this when reviewing a later patch: why do we lose the
> i_count check here? There's no point in adding an inode that is still
> in use onto the LRU - we'll just remove it again once we find it
> during LRU scanning.
I did it this way because we're already holding the lock. But with the
inode and lru lists locked seperately in a subsequent patch, it is
better to check the count, I agree.
next prev parent reply other threads:[~2010-10-16 7:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 0:15 fs: Inode cache scalability V3 Dave Chinner
2010-10-13 0:15 ` [PATCH 01/18] kernel: add bl_list Dave Chinner
2010-10-13 0:15 ` [PATCH 02/18] fs: Convert nr_inodes and nr_unused to per-cpu counters Dave Chinner
2010-10-13 0:15 ` [PATCH 03/18] fs: Implement lazy LRU updates for inodes Dave Chinner
2010-10-13 13:32 ` Christoph Hellwig
2010-10-16 0:11 ` Dave Chinner
2010-10-16 7:56 ` Nick Piggin [this message]
2010-10-13 0:15 ` [PATCH 04/18] fs: inode split IO and LRU lists Dave Chinner
2010-10-13 11:31 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 05/18] fs: Clean up inode reference counting Dave Chinner
2010-10-13 11:33 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 06/18] exofs: use iput() for inode reference count decrements Dave Chinner
2010-10-13 11:34 ` Christoph Hellwig
2010-10-13 14:49 ` Boaz Harrosh
2010-10-17 1:24 ` Christoph Hellwig
2010-10-24 18:06 ` Boaz Harrosh
2010-10-13 0:15 ` [PATCH 07/18] fs: rework icount to be a locked variable Dave Chinner
2010-10-13 11:36 ` Christoph Hellwig
2010-10-16 0:15 ` Dave Chinner
2010-10-16 0:20 ` Dave Chinner
2010-10-16 0:23 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 08/18] fs: Factor inode hash operations into functions Dave Chinner
2010-10-13 0:15 ` [PATCH 09/18] fs: Introduce per-bucket inode hash locks Dave Chinner
2010-10-13 11:41 ` Christoph Hellwig
2010-10-13 15:05 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 10/18] fs: add a per-superblock lock for the inode list Dave Chinner
2010-10-13 0:15 ` [PATCH 11/18] fs: split locking of inode writeback and LRU lists Dave Chinner
2010-10-13 3:26 ` Lin Ming
2010-10-13 3:26 ` Lin Ming
2010-10-13 13:18 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 12/18] fs: Protect inode->i_state with the inode->i_lock Dave Chinner
2010-10-13 13:27 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 13/18] fs: introduce a per-cpu last_ino allocator Dave Chinner
2010-10-13 0:15 ` [PATCH 14/18] fs: Make iunique independent of inode_lock Dave Chinner
2010-10-13 0:15 ` [PATCH 15/18] fs: icache remove inode_lock Dave Chinner
2010-10-13 2:09 ` Dave Chinner
2010-10-13 13:42 ` Christoph Hellwig
2010-10-13 0:15 ` [PATCH 16/18] fs: Reduce inode I_FREEING and factor inode disposal Dave Chinner
2010-10-13 13:51 ` Christoph Hellwig
2010-10-13 0:16 ` [PATCH 17/18] fs: split __inode_add_to_list Dave Chinner
2010-10-13 15:08 ` Christoph Hellwig
2010-10-13 0:16 ` [PATCH 18/18] fs: do not assign default i_ino in new_inode Dave Chinner
2010-10-16 7:57 ` Nick Piggin
2010-10-16 16:30 ` Christoph Hellwig
2010-10-13 14:51 ` fs: Inode cache scalability V3 Christoph Hellwig
2010-10-13 15:58 ` Christoph Hellwig
2010-10-13 21:46 ` Christoph Hellwig
2010-10-13 23:36 ` Christoph Hellwig
2010-10-13 23:55 ` Dave Chinner
2010-10-14 0:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016075658.GN19147@amd \
--to=npiggin@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.