All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Robin Holt <holt@sgi.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: ftrace does not work on cpus > 999.
Date: Sat, 16 Oct 2010 16:45:33 +0200	[thread overview]
Message-ID: <20101016144529.GA5384@nowhere> (raw)
In-Reply-To: <20101016131505.GW14064@sgi.com>

On Sat, Oct 16, 2010 at 08:15:05AM -0500, Robin Holt wrote:
> Just started looking into using ftrace to identify a difficult to diagnose
> userland set of processes when I noticed that the .../trace/per_cpu
> directory only contains entries for cpus 0-999.  I have not looked at
> what else may not work.  For the cpus that are listed, I am able to grep
> trace buffer information so it is mostly working.
> 
> I will be away from email for most of today, but may get back to this
> tonight.  If there are any suggestions, I will happily give them a try.
> 
> Thanks,
> Robin


Oh!

Can you please try that?

Thanks.


diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 9ec59f5..3565f9e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3999,7 +3999,7 @@ static void tracing_init_debugfs_percpu(long cpu)
 	/* strlen(cpu) + MAX(log10(cpu)) + '\0' */
 	char cpu_dir[7];
 
-	if (cpu > 999 || cpu < 0)
+	if (cpu < 0)
 		return;
 
 	sprintf(cpu_dir, "cpu%ld", cpu);



  reply	other threads:[~2010-10-16 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-16 13:15 ftrace does not work on cpus > 999 Robin Holt
2010-10-16 14:45 ` Frederic Weisbecker [this message]
2010-10-16 15:17   ` Steven Rostedt
2010-10-16 16:16     ` Ingo Molnar
2010-10-16 16:32       ` Steven Rostedt
2010-10-16 16:32       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101016144529.GA5384@nowhere \
    --to=fweisbec@gmail.com \
    --cc=holt@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.