From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: invalidate_inode_buffers call in invalidate_list?
Date: Sun, 17 Oct 2010 22:18:52 -0400 [thread overview]
Message-ID: <20101018021852.GA26485@infradead.org> (raw)
In-Reply-To: <20101018011150.GI29677@dastard>
On Mon, Oct 18, 2010 at 12:11:50PM +1100, Dave Chinner wrote:
> > While we're
> > at it - any reaso not to consider I_NEW inodes as busy in
> > invalidate_list?
>
> Not that I can think of. I'd probably leave the WARN_ON() condition
> there, though, so that if we do ever encounter them we hear about
> it...
The WARN_ON is already unreachable - we check for I_NEW a couple
of lines above and never drop it until after we reach the WARN_ON.
prev parent reply other threads:[~2010-10-18 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 23:39 invalidate_inode_buffers call in invalidate_list? Christoph Hellwig
2010-10-18 1:11 ` Dave Chinner
2010-10-18 2:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018021852.GA26485@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.