From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1P7ueR-00045D-7t for user-mode-linux-devel@lists.sourceforge.net; Mon, 18 Oct 2010 18:41:39 +0000 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1P7ueO-0002pc-T1 for user-mode-linux-devel@lists.sourceforge.net; Mon, 18 Oct 2010 18:41:39 +0000 Date: Mon, 18 Oct 2010 11:40:39 -0700 From: Andrew Morton Message-Id: <20101018114039.503233da.akpm@linux-foundation.org> In-Reply-To: <1287419814-20086-1-git-send-email-richard@nod.at> References: <1287419814-20086-1-git-send-email-richard@nod.at> Mime-Version: 1.0 Subject: Re: [uml-devel] [PATCH 1/1] hostfs: fix UML crash List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Richard Weinberger Cc: toralf.foerster@gmx.de, jdike@addtoit.com, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, viro@zeniv.linux.org.uk On Mon, 18 Oct 2010 18:36:54 +0200 Richard Weinberger wrote: > 365b1818 resized f_spare within struct statfs. > hostfs accesses f_spare directly and needs an update. > > Signed-off-by: Richard Weinberger > Reported-by: Toralf F__rster > Tested-by: Toralf F__rster > --- > fs/hostfs/hostfs_user.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/hostfs/hostfs_user.c b/fs/hostfs/hostfs_user.c > index 6777aa0..ce2f168 100644 > --- a/fs/hostfs/hostfs_user.c > +++ b/fs/hostfs/hostfs_user.c > @@ -388,6 +388,6 @@ int do_statfs(char *root, long *bsize_out, long long *blocks_out, > spare_out[1] = buf.f_spare[1]; > spare_out[2] = buf.f_spare[2]; > spare_out[3] = buf.f_spare[3]; > - spare_out[4] = buf.f_spare[4]; > + > return 0; > } Thanks. Is there any reason for hostfs to be playing with the f_spare field at all? ------------------------------------------------------------------------------ Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platforms. Download your free trials today! http://p.sf.net/sfu/adobe-dev2dev _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757682Ab0JRSlr (ORCPT ); Mon, 18 Oct 2010 14:41:47 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52482 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757651Ab0JRSlq (ORCPT ); Mon, 18 Oct 2010 14:41:46 -0400 Date: Mon, 18 Oct 2010 11:40:39 -0700 From: Andrew Morton To: Richard Weinberger Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net, viro@zeniv.linux.org.uk, toralf.foerster@gmx.de Subject: Re: [PATCH 1/1] hostfs: fix UML crash Message-Id: <20101018114039.503233da.akpm@linux-foundation.org> In-Reply-To: <1287419814-20086-1-git-send-email-richard@nod.at> References: <1287419814-20086-1-git-send-email-richard@nod.at> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Oct 2010 18:36:54 +0200 Richard Weinberger wrote: > 365b1818 resized f_spare within struct statfs. > hostfs accesses f_spare directly and needs an update. > > Signed-off-by: Richard Weinberger > Reported-by: Toralf F__rster > Tested-by: Toralf F__rster > --- > fs/hostfs/hostfs_user.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/hostfs/hostfs_user.c b/fs/hostfs/hostfs_user.c > index 6777aa0..ce2f168 100644 > --- a/fs/hostfs/hostfs_user.c > +++ b/fs/hostfs/hostfs_user.c > @@ -388,6 +388,6 @@ int do_statfs(char *root, long *bsize_out, long long *blocks_out, > spare_out[1] = buf.f_spare[1]; > spare_out[2] = buf.f_spare[2]; > spare_out[3] = buf.f_spare[3]; > - spare_out[4] = buf.f_spare[4]; > + > return 0; > } Thanks. Is there any reason for hostfs to be playing with the f_spare field at all?