From: Luiz Capitulino <lcapitulino@redhat.com>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Ananth Narayan <ananth@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing
Date: Mon, 18 Oct 2010 12:21:56 -0200 [thread overview]
Message-ID: <20101018122156.3410da09@doriath> (raw)
In-Reply-To: <20101018113655.09b6a48d@zephyr>
On Mon, 18 Oct 2010 11:36:55 +0530
Prerna Saxena <prerna@linux.vnet.ibm.com> wrote:
> This patch set introduces two QMP interfaces for tracing :
>
> * query-trace : to list current contents of trace-buffer
> * query-trace-events : to list all available trace-events with their state.
This is in my to-review queue, but it's going to take a few days, because
I have to take a deeper look at the tracing feature to be able to review it.
Two initial questions:
o This is labeled as an RFC, but you're versioning it. Should this be
considered for inclusion?
o Is this really useful w/o being able to set new traces?
>
> Changelog :
> -----------
> Changes v2 -> v3 :
> - Change declarations of st_print_trace_to_qlist() and
> st_print_trace_events_to_qlist() to return QList*
>
> Changes v1 -> v2 :
> - Add 'timestamp' field for query-trace output.
> - Misc cleanups.
>
next prev parent reply other threads:[~2010-10-18 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 6:06 [Qemu-devel] [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing Prerna Saxena
2010-10-18 6:14 ` [Qemu-devel] [Tracing][RFC v3 PATCH 1/2] Introduce QMP interfaces : query-trace & query-trace-events Prerna Saxena
2010-10-18 6:15 ` [Qemu-devel] [Tracing][RFC v3 PATCH 2/2] Add documentation for QMP commands: " Prerna Saxena
2010-10-18 14:21 ` Luiz Capitulino [this message]
2010-10-19 5:16 ` [Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing Prerna Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018122156.3410da09@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=mahesh@linux.vnet.ibm.com \
--cc=prerna@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.