From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [BISECTED, -next] drm/i915: blurred HDMI output
Date: Mon, 18 Oct 2010 14:05:05 -0700
Message-ID: <20101018140505.44b04a09@jbarnes-desktop>
References: <201010171937.13642.arnd@arndb.de>
	<20101018131523.19f71ca3@jbarnes-desktop>
	<201010182230.17669.arnd@arndb.de>
	<201010182237.44267.arnd@arndb.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com
	[67.222.39.38])
	by gabe.freedesktop.org (Postfix) with SMTP id A36F09E774
	for <dri-devel@lists.freedesktop.org>;
	Mon, 18 Oct 2010 14:06:00 -0700 (PDT)
In-Reply-To: <201010182237.44267.arnd@arndb.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Arnd Bergmann <arnd@arndb.de>
Cc: Wessel <jason.wessel@windriver.com>, Jason@freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Mon, 18 Oct 2010 22:37:43 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> On Monday 18 October 2010 22:30:17 Arnd Bergmann wrote:
> 
> > I don't think the code path you patch here actually gets used, since
> > intel_lvds_init gets called by intel_setup_outputs only for mobile devices.
> 
> FWIW, the patch below does work.
> 
> 	Arnd
> 
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5311,6 +5311,9 @@ static void intel_setup_outputs(struct drm_device *dev)
>  	if (IS_MOBILE(dev) && !IS_I830(dev))
>  		intel_lvds_init(dev);
>  
> +       I915_WRITE(PFIT_CONTROL, 0);
> +       I915_WRITE(LVDS, 0);
> +
>  	if (HAS_PCH_SPLIT(dev)) {
>  		dpd_is_edp = intel_dpd_is_edp(dev);

Oh of course, I was thinking the output functions did detection, but we
short circuit it before that.

So we should probably do it in setup_outputs or init_display once we've
figured out there's no LVDS.  It's cool that the panel fitter still has
an effect even on non-LVDS platforms though, maybe we really should
treat it as a part of the CRTC rather than the LVDS encoder after all.

-- 
Jesse Barnes, Intel Open Source Technology Center