From: "Ted Ts'o" <tytso@mit.edu>
To: Mike Frysinger <vapier@gentoo.org>,
Peter Zijlstra <peterz@infradead.org>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels
Date: Mon, 18 Oct 2010 10:54:00 -0400 [thread overview]
Message-ID: <20101018145400.GD4120@thunk.org> (raw)
In-Reply-To: <20101018143935.GA4120@thunk.org>
On Mon, Oct 18, 2010 at 10:39:35AM -0400, Ted Ts'o wrote:
> On Sun, Oct 17, 2010 at 04:26:25PM -0400, Mike Frysinger wrote:
> > On Sun, Oct 17, 2010 at 16:01, Peter Zijlstra wrote:
> > > On Sun, 2010-10-17 at 15:49 -0400, Mike Frysinger wrote:
> > >> sounds like a good reason to shut up the new unintended warnings
> > >
> > > I'm failing to see any logic there, old code doesn't generate warnings,
> > > its new code that would, and new code should never have any whitespace
> > > in front of labels.
> >
> > it's a waste of time to massage code to one person's opinion
>
> +1
>
> It's not in CondingStyle; I prefer to outdent labels by one tab stop:
Note that there is absolutely nothing about how labels should be
indented in CodingStyle at all, and I very much resist code
straightjackets being imposed by checkpatch.pl implementors.
Can we please stop this nonsense?
- Ted
next prev parent reply other threads:[~2010-10-18 14:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 8:05 [PATCH] checkpatch: allow single space before labels Mike Frysinger
2010-10-17 8:21 ` Joe Perches
2010-10-17 8:24 ` Mike Frysinger
2010-10-17 10:21 ` Peter Zijlstra
2010-10-17 10:30 ` Mike Frysinger
2010-10-17 10:37 ` Peter Zijlstra
2010-10-17 10:52 ` Mike Frysinger
2010-10-17 16:54 ` Joe Perches
2010-10-17 19:30 ` Peter Zijlstra
2010-10-17 19:38 ` Joe Perches
2010-10-17 19:49 ` Peter Zijlstra
2010-10-17 19:49 ` Mike Frysinger
2010-10-17 20:01 ` Peter Zijlstra
2010-10-17 20:26 ` Mike Frysinger
2010-10-18 14:39 ` Ted Ts'o
2010-10-18 14:54 ` Ted Ts'o [this message]
2010-10-18 14:58 ` Peter Zijlstra
2010-10-18 15:03 ` Peter Zijlstra
2010-10-18 18:21 ` Mike Frysinger
2010-10-18 18:32 ` Peter Zijlstra
2010-10-18 19:09 ` Joe Perches
2010-10-17 10:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018145400.GD4120@thunk.org \
--to=tytso@mit.edu \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.