From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
linux-bluetooth@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
steven miao <realmz6@gmail.com>
Subject: Re: [PATCH] bluetooth: fix unaligned access to l2cap conf data
Date: Mon, 18 Oct 2010 13:59:16 -0200 [thread overview]
Message-ID: <20101018155916.GB2468@vigoh> (raw)
In-Reply-To: <1287402706.3316.126.camel@aeonflux>
Hi Mike,
* Marcel Holtmann <marcel@holtmann.org> [2010-10-18 13:51:46 +0200]:
> Hi Mike,
>
> > In function l2cap_get_conf_opt() and l2cap_add_conf_opt() the address of
> > opt->val sometimes is not at the edge of 2-bytes/4-bytes, so 2-bytes/4 bytes
> > access will cause data misalignment exeception. Use get_unaligned_le16/32
> > and put_unaligned_le16/32 function to avoid data misalignment execption.
> >
> > Signed-off-by: steven miao <realmz6@gmail.com>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > was posted a month ago with no feedback ...
>
> must have slipped through. However I don't remember it being on
> linux-bluetooth at all. Maybe it was on the other mailing lists :(
Actually I remember it, but it got lost by some way. :(
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
Applied, thanks.
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-10-18 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 22:29 [PATCH] bluetooth: fix unaligned access to l2cap conf data Mike Frysinger
2010-10-18 11:51 ` Marcel Holtmann
2010-10-18 15:59 ` Gustavo F. Padovan [this message]
2010-10-18 18:17 ` Harvey Harrison
2010-10-18 18:17 ` Harvey Harrison
2010-10-18 16:32 ` Gustavo F. Padovan
2010-10-18 16:32 ` Gustavo F. Padovan
2010-10-18 19:10 ` Mike Frysinger
2010-10-18 19:10 ` Mike Frysinger
2010-10-18 19:12 ` Gustavo F. Padovan
2010-10-18 19:12 ` Gustavo F. Padovan
2010-10-18 19:39 ` Mike Frysinger
2010-10-18 19:39 ` Mike Frysinger
[not found] <1283149112-22164-1-git-send-email-realmz6@gmail.com>
2010-09-17 3:13 ` [PATCH] Bluetooth: Fix " real mz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018155916.GB2468@vigoh \
--to=padovan@profusion.mobi \
--cc=akpm@linux-foundation.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=realmz6@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.