diff for duplicates of <20101018160830.GB9033@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index de598e9..a8c388e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -119,7 +119,8 @@ Can you move this up a bit, ahead of SENSORS_FSCHMD ? Trying to stay in sequence > + > +static void fan_alarm_notify(struct work_struct *ws) > +{ -> + struct gpio_fan_data *fan_data > + container_of(ws, struct gpio_fan_data, alarm_work); +> + struct gpio_fan_data *fan_data = +> + container_of(ws, struct gpio_fan_data, alarm_work); > + > + sysfs_notify(&fan_data->pdev->dev.kobj, NULL, "fan1_alarm"); > + kobject_uevent(&fan_data->pdev->dev.kobj, KOBJ_CHANGE); @@ -291,7 +292,7 @@ Return value can be rpm or error. { } not needed here. -> + if (speed[i].ctrl_val = ctrl_val) { +> + if (speed[i].ctrl_val == ctrl_val) { > + *rpm = speed[i].rpm; > + return 0; > + } @@ -382,7 +383,7 @@ since the information is provided anyway. > + if (strict_strtoul(buf, 10, &val) || val > 1) > + return -EINVAL; > + -> + if (fan_data->pwm_enable = val) +> + if (fan_data->pwm_enable == val) > + return count; > + > + mutex_lock(&fan_data->lock); @@ -390,7 +391,7 @@ since the information is provided anyway. > + fan_data->pwm_enable = val; > + > + /* Disable manual control mode: set fan at full speed. */ -> + if (val = 0) { +> + if (val == 0) { > + ctrl_val = fan_data->speed[fan_data->num_speed - 1].ctrl_val; > + if (ctrl_val != fan_data->ctrl_val) > + set_fan_ctrl(fan_data, ctrl_val); @@ -683,8 +684,3 @@ writes a driver (hint, hint, dns323) using it. Guenter Roeck Distinguished Engineer PDU IP Systems - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 5189822..9b740f1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020101017154021.GB29120@kw.sim.vm.gnt\0" "ref\01287330612-11256-1-git-send-email-simon@sequanux.org\0" - "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH 1/2] hwmon: add generic GPIO fan driver\0" - "Date\0Mon, 18 Oct 2010 16:08:30 +0000\0" + "From\0guenter.roeck@ericsson.com (Guenter Roeck)\0" + "Subject\0[PATCH 1/2] hwmon: add generic GPIO fan driver\0" + "Date\0Mon, 18 Oct 2010 09:08:30 -0700\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -127,7 +127,8 @@ "> +\n" "> +static void fan_alarm_notify(struct work_struct *ws)\n" "> +{\n" - "> + struct gpio_fan_data *fan_data > + container_of(ws, struct gpio_fan_data, alarm_work);\n" + "> + struct gpio_fan_data *fan_data =\n" + "> + container_of(ws, struct gpio_fan_data, alarm_work);\n" "> +\n" "> + sysfs_notify(&fan_data->pdev->dev.kobj, NULL, \"fan1_alarm\");\n" "> + kobject_uevent(&fan_data->pdev->dev.kobj, KOBJ_CHANGE);\n" @@ -299,7 +300,7 @@ "\n" "\t{ } not needed here.\n" "\n" - "> + if (speed[i].ctrl_val = ctrl_val) {\n" + "> + if (speed[i].ctrl_val == ctrl_val) {\n" "> + *rpm = speed[i].rpm;\n" "> + return 0;\n" "> + }\n" @@ -390,7 +391,7 @@ "> + if (strict_strtoul(buf, 10, &val) || val > 1)\n" "> + return -EINVAL;\n" "> +\n" - "> + if (fan_data->pwm_enable = val)\n" + "> + if (fan_data->pwm_enable == val)\n" "> + return count;\n" "> +\n" "> + mutex_lock(&fan_data->lock);\n" @@ -398,7 +399,7 @@ "> + fan_data->pwm_enable = val;\n" "> +\n" "> + /* Disable manual control mode: set fan at full speed. */\n" - "> + if (val = 0) {\n" + "> + if (val == 0) {\n" "> + ctrl_val = fan_data->speed[fan_data->num_speed - 1].ctrl_val;\n" "> + if (ctrl_val != fan_data->ctrl_val)\n" "> + set_fan_ctrl(fan_data, ctrl_val);\n" @@ -690,11 +691,6 @@ "-- \n" "Guenter Roeck\n" "Distinguished Engineer\n" - "PDU IP Systems\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + PDU IP Systems -fe7e0588b1528f1bf564bf39d652822fd331e799e6310afbe4561d5cc820357a +21afcbe2d6227397405cc0cc52b01ba89d01d53600e6d884d0da1baa380a13cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.