From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 18 Oct 2010 21:55:04 +0200
Subject: [U-Boot] [PATCH] mpc83xx: fix 837x MDS PCI HOST build
In-Reply-To: <1285873751.28947.19984.camel@petert>
References: <20100930134034.7dab7977.kim.phillips@freescale.com>
	<1285873751.28947.19984.camel@petert>
Message-ID: <20101018195504.B7390136320@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Peter Tyser,

In message <1285873751.28947.19984.camel@petert> you wrote:
>
> > commit 6aa3d3bfaa986f1aff5e21a9b9f68d087715b1a9
> > "83xx: Remove warmboot parameter from PCI init functions" missed
> > one mpc83xx_pcie_init callsite, causing this build error:
> > 
> > Configuring for MPC837XEMDS_HOST board...
> > pci.c: In function 'pci_init_board':
> > pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
> > 
> > this patch extends the commit to include that callsite.
> 
> Thanks for catching that.  Should the MPC837XEMDS MAKEALL target be
> changed to MPC837XEMDS_HOST to include coverage of its PCI code?  I
> tried running ./MAKEALL 83xx prior to submitting the offending change,
> but didn't catch this issue.  Same for the MPC832XEMDS?

Not needed any more. The new MAKEALL auto-generates the list of board
configurations from boards.cfg, so we don't miss such cases any
longer.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I like your game but we have to change the rules."