From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/2] sound/soc/davinci/davinci-mcasp.c: Return error code in failure Date: Mon, 18 Oct 2010 16:31:45 -0700 Message-ID: <20101018233112.GA26745@opensource.wolfsonmicro.com> References: <1287411074-19825-1-git-send-email-julia@diku.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id F0ACC10390A for ; Tue, 19 Oct 2010 02:13:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1287411074-19825-1-git-send-email-julia@diku.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Julia Lawall Cc: alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, Oct 18, 2010 at 04:11:13PM +0200, Julia Lawall wrote: > In this code, 0 is returned on failure, even though other > failures return -ENOMEM or other similar values. Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 18 Oct 2010 23:31:45 +0000 Subject: Re: [PATCH 1/2] sound/soc/davinci/davinci-mcasp.c: Return error Message-Id: <20101018233112.GA26745@opensource.wolfsonmicro.com> List-Id: References: <1287411074-19825-1-git-send-email-julia@diku.dk> In-Reply-To: <1287411074-19825-1-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood On Mon, Oct 18, 2010 at 04:11:13PM +0200, Julia Lawall wrote: > In this code, 0 is returned on failure, even though other > failures return -ENOMEM or other similar values. Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476Ab0JSANg (ORCPT ); Mon, 18 Oct 2010 20:13:36 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:47358 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752133Ab0JSANf (ORCPT ); Mon, 18 Oct 2010 20:13:35 -0400 Date: Mon, 18 Oct 2010 16:31:45 -0700 From: Mark Brown To: Julia Lawall Cc: Liam Girdwood , kernel-janitors@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] sound/soc/davinci/davinci-mcasp.c: Return error code in failure Message-ID: <20101018233112.GA26745@opensource.wolfsonmicro.com> References: <1287411074-19825-1-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287411074-19825-1-git-send-email-julia@diku.dk> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2010 at 04:11:13PM +0200, Julia Lawall wrote: > In this code, 0 is returned on failure, even though other > failures return -ENOMEM or other similar values. Applied, thanks.