Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation error with -fstack-protector and -Werror

[Frederic Weisbecker <fweisbec@gmail.com>]

On Tue, Oct 19, 2010 at 02:24:00AM +0300, Brian Gitonga Marete wrote:
> The following patch fixes compilation of the perf user-space tools on,
> for example, gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4) . It should not
> break anything else.



Hi,

What kind of warning have you encountered and why it fixes it?
Can you describe that in your changelog?

Thanks.



> 
> Signed-off-by: Brian Gitonga Marete <marete@toshnix.com>
> ---
>  tools/perf/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 1950e19..64eb2ea 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -288,7 +288,7 @@ endif
>  -include feature-tests.mak
> 
>  ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -fstack-protector-all),y)
> -	CFLAGS := $(CFLAGS) -fstack-protector-all
> +	CFLAGS := $(CFLAGS) -fstack-protector-all --param ssp-buffer-size=1
>  endif
> 
> -- 
> Brian Gitonga Marete
> Toshnix Systems
> Tel: +254722151590
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/