Re: [PATCH] sst: Intel SST audio driver

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Mon, Oct 18, 2010 at 11:24:18AM +0100, Alan Cox wrote:
> > Because it's not using the relevant framework at all, it's gone and
> > reinvented the wheel without a pressing reason to do so and this will
> > be very likely to create problems if the part is at all successful.

> Its more a case of predating the wheel as far as I can tell. In terms

ASoC has been in mainline since 2.6.21 which I imagine predates the
Moorestown code.

> of frameworks I don't think it matters as of itself - but once that
> means you have to write two different versions of the same codec chip
> driver for example yes it matters.

Yes, exactly - this is the big problem.  It's often much worse than just
two different versions, with these things it's easy to end up having to
have versions per board.

> Putting it in staging allows that work to be done in public in a
> meaningful way where the code and changes get review.

I agree with the approach you're outlining here.