All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruno Randolf <br1@einfach.org>
To: randy.dunlap@oracle.com, br1@einfach.org,
	akpm@linux-foundation.org, kevin.granade@gmail.com
Cc: blp@cs.stanford.edu, linux-kernel@vger.kernel.org
Subject: [PATCH v2] Add generic exponentially weighted moving average function
Date: Tue, 19 Oct 2010 17:36:35 +0900	[thread overview]
Message-ID: <20101019083635.32294.67087.stgit@localhost6.localdomain6> (raw)

This adds a generic exponentially weighted moving average function. This
implementation makes use of a structure which keeps a scaled up internal
representation to reduce rounding errors.

The idea for this implementation comes from the rt2x00 driver (rt2x00link.c)
and I would like to use it in several places in the mac80211 and ath5k code.

Signed-off-by: Bruno Randolf <br1@einfach.org>

--
v2: Renamed 'samples' to 'weight'. Added more documentation. Use avg_val
    pointer. Add a WARN_ON_ONCE for invalid values of 'weight'. Divide
    and round up/down.
---
 include/linux/average.h |   37 +++++++++++++++++++++++++++++++++++++
 1 files changed, 37 insertions(+), 0 deletions(-)
 create mode 100644 include/linux/average.h

diff --git a/include/linux/average.h b/include/linux/average.h
new file mode 100644
index 0000000..55e4317
--- /dev/null
+++ b/include/linux/average.h
@@ -0,0 +1,37 @@
+#ifndef _LINUX_AVERAGE_H
+#define _LINUX_AVERAGE_H
+
+#define AVG_FACTOR	1000
+
+struct avg_val {
+	int value;
+	int internal;
+};
+
+/**
+ * moving_average() -  Exponentially weighted moving average (EWMA)
+ * @avg: Average structure
+ * @val: Current value
+ * @weight: This defines how fast the influence of older values decreases.
+ *	Has to be higher than 1. Use the same number every time you call this
+ *	function for a single struct avg_val!
+ *
+ * This implementation make use of a struct avg_val which keeps a scaled up
+ * internal representation to prevent rounding errors. Due to this, the maximum
+ * range of values is MAX_INT/(AVG_FACTOR*weight).
+ *
+ * The current average value can be accessed by using avg_val.value.
+ */
+static inline void
+moving_average(struct avg_val *avg, const int val, const int weight)
+{
+	if (WARN_ON_ONCE(weight <= 1))
+		return;
+	avg->internal = avg->internal  ?
+		(((avg->internal * (weight - 1)) +
+			(val * AVG_FACTOR)) / weight) :
+		(val * AVG_FACTOR);
+	avg->value = DIV_ROUND_CLOSEST(avg->internal, AVG_FACTOR);
+}
+
+#endif /* _LINUX_AVERAGE_H */


             reply	other threads:[~2010-10-19  8:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  8:36 Bruno Randolf [this message]
2010-10-19 13:22 ` [PATCH v2] Add generic exponentially weighted moving average function kevin granade
2010-10-19 21:16 ` Randy Dunlap
2010-10-19 22:37 ` Andrew Morton
2010-10-19 22:37   ` Andrew Morton
2010-10-19 22:54   ` Andrew Morton
2010-10-19 22:54     ` Andrew Morton
2010-10-20  2:42     ` Bruno Randolf
2010-10-20  2:42       ` Bruno Randolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101019083635.32294.67087.stgit@localhost6.localdomain6 \
    --to=br1@einfach.org \
    --cc=akpm@linux-foundation.org \
    --cc=blp@cs.stanford.edu \
    --cc=kevin.granade@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.