From: Samuel Ortiz <sameo@linux.intel.com>
To: Mike Rapoport <mike@compulab.co.il>
Cc: achew@nvidia.com, axel.lin@gmail.com, gking@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mfd: Add TPS658621C device ID
Date: Tue, 19 Oct 2010 11:10:07 +0200 [thread overview]
Message-ID: <20101019091006.GB2736@sortiz-mobl> (raw)
In-Reply-To: <4CAC1347.3000301@compulab.co.il>
Hi Mike, Andrew,
On Wed, Oct 06, 2010 at 08:12:23AM +0200, Mike Rapoport wrote:
> Hi Samuel,
>
> Can you please queue this?
>
Patch applied now, many thanks.
Cheers,
Samuel.
> achew@nvidia.com wrote:
> >From: Andrew Chew <achew@nvidia.com>
> >
> >The interface for this device should be identical to that of the
> >TPS658521A.
> >
> >Signed-off-by: Andrew Chew <achew@nvidia.com>
>
> Acked-by: Mike Rapoport <mike@compulab.co.il>
>
> >---
> > drivers/mfd/tps6586x.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> >index 117eb7c..b4931ab 100644
> >--- a/drivers/mfd/tps6586x.c
> >+++ b/drivers/mfd/tps6586x.c
> >@@ -47,6 +47,7 @@
> > /* device id */
> > #define TPS6586X_VERSIONCRC 0xcd
> > #define TPS658621A_VERSIONCRC 0x15
> >+#define TPS658621C_VERSIONCRC 0x2c
> > struct tps6586x_irq_data {
> > u8 mask_reg;
> >@@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
> > return -EIO;
> > }
> >- if (ret != TPS658621A_VERSIONCRC) {
> >+ if ((ret != TPS658621A_VERSIONCRC) &&
> >+ (ret != TPS658621C_VERSIONCRC)) {
> > dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
> > return -ENODEV;
> > }
>
>
> --
> Sincerely yours,
> Mike.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-10-19 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 22:32 [PATCH 1/1] mfd: Add TPS658621C device ID achew
2010-10-06 6:12 ` Mike Rapoport
2010-10-19 9:10 ` Samuel Ortiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-12 21:24 Andrew Chew
2010-10-13 6:04 ` Mike Rapoport
2010-10-13 8:20 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019091006.GB2736@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=achew@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=gking@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.