From: Ingo Molnar <mingo@elte.hu>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>,
lkml <linux-kernel@vger.kernel.org>,
"Chen, Tim C" <tim.c.chen@intel.com>
Subject: Re: [patch]x86: spread tlb flush vector between nodes
Date: Tue, 19 Oct 2010 12:37:59 +0200 [thread overview]
Message-ID: <20101019103759.GC32212@elte.hu> (raw)
In-Reply-To: <1287478532.9456.0.camel@sli10-conroe.sh.intel.com>
* Shaohua Li <shaohua.li@intel.com> wrote:
> On Tue, 2010-10-19 at 16:44 +0800, Ingo Molnar wrote:
> > * H. Peter Anvin <hpa@zytor.com> wrote:
> >
> > > Technically, it is way too late for anything new in this merge window, but we can
> > > try to make a reasonable assessment of the risk since the merge window got
> > > delayed. However, this close to the merge window you cannot just expect to be
> > > merged even if the patch itself is OK.
> >
> > a prompt re-send of the patch today-ish, with proper changelog, etc. and with
> > the new tuning in place is definitely a must.
>
> the previous patch has changelog. what did you mean a new tuning?
The new tuning would be the 8->32 patch - but that would be a more complex and
separate (and definitely controversial) patch anyway.
So if hpa gives his ack we can try this current spread-tlb-vectors-better patch in
-tip and see how it fares. Could you please update the changelog to specify the 20%
improvement more precisely? What kind of workload was used and how was the
improvement measured?
Thanks,
Ingo
next prev parent reply other threads:[~2010-10-19 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 7:41 [patch]x86: spread tlb flush vector between nodes Shaohua Li
2010-10-13 8:16 ` Andi Kleen
2010-10-13 8:39 ` Shaohua Li
2010-10-13 11:19 ` Ingo Molnar
2010-10-19 5:39 ` Shaohua Li
2010-10-19 6:21 ` H. Peter Anvin
2010-10-19 8:44 ` Ingo Molnar
2010-10-19 8:55 ` Shaohua Li
2010-10-19 10:37 ` Ingo Molnar [this message]
2010-10-19 13:28 ` Shaohua Li
2010-10-19 13:34 ` Andi Kleen
2010-10-20 1:13 ` Shaohua Li
2010-10-20 2:39 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019103759.GC32212@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.