From: Bandan Das <bandan.das@stratus.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: make br_parse_ip_options static
Date: Tue, 19 Oct 2010 12:03:11 -0400 [thread overview]
Message-ID: <20101019160311.GD12005@stratus.com> (raw)
In-Reply-To: <20101019075503.057dd8d6@nehalam>
> >
> > My main motivation behind not making this static was that
> > there would be possibly other places in the bridge code
> > (besides br_netfilter.c) where we enter the IP stack and might
> > want to call this. Not sure if it's indeed the case though..
> >
>
> I checked by doing make allmodconfig as well as looking by
> git grep 'br_parse_ip_options'
>
> --
Sorry, my wording was misleading :) What I meant was at this time,
it's only used in br_netfilter.c but may be sometime in the future,
it could possible be used in some other places where we enter the IP
stack from the bridge code.
But, I completely agree with you. It makes more sense to make it static
as of now.
Bandan
next prev parent reply other threads:[~2010-10-19 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 0:03 [PATCH] bridge: make br_parse_ip_options static Stephen Hemminger
2010-10-19 11:22 ` Bandan Das
2010-10-19 14:55 ` Stephen Hemminger
2010-10-19 16:03 ` Bandan Das [this message]
2010-10-21 10:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019160311.GD12005@stratus.com \
--to=bandan.das@stratus.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.