From: Andrew Morton <akpm@linux-foundation.org>
To: pavan_savoy@ti.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging
Date: Tue, 19 Oct 2010 22:22:20 -0700 [thread overview]
Message-ID: <20101019222220.892e67e4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1286381895-11329-2-git-send-email-pavan_savoy@ti.com>
On Wed, 6 Oct 2010 12:18:14 -0400 pavan_savoy@ti.com wrote:
> +/**
> + * st_reg_complete -
> + * to call registration complete callbacks
> + * of all protocol stack drivers
> + */
> +void st_reg_complete(struct st_data_s *st_gdata, char err)
The driver has a lot of "kerneldoc" comments which are incomplete -
they don't document the arguments.
next prev parent reply other threads:[~2010-10-20 5:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 16:18 [PATCH 0/2] move TI_ST driver out of staging pavan_savoy
2010-10-06 15:28 ` Greg KH
2010-10-06 16:10 ` Savoy, Pavan
2010-10-06 16:18 ` [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging pavan_savoy
2010-10-06 16:18 ` [PATCH 2/2] drivers:misc: ti-st: Kconfig & Makefile for TI_ST pavan_savoy
2010-10-06 19:47 ` [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging Jiri Slaby
2010-10-06 20:08 ` Savoy, Pavan
2010-10-06 22:18 ` Jiri Slaby
2010-10-06 22:36 ` Savoy, Pavan
2010-10-07 7:58 ` Jiri Slaby
2010-10-07 14:52 ` Savoy, Pavan
2010-10-07 18:26 ` Jiri Slaby
2010-10-07 18:35 ` Savoy, Pavan
2010-10-07 19:38 ` Alan Cox
2010-10-07 19:19 ` Savoy, Pavan
2010-10-07 20:35 ` Alan Cox
2010-10-07 20:17 ` Savoy, Pavan
2010-10-07 20:59 ` Alan Cox
2010-10-07 20:46 ` Savoy, Pavan
2010-10-08 8:32 ` Marcel Holtmann
2010-10-20 5:22 ` Andrew Morton [this message]
2010-10-20 16:03 ` Savoy, Pavan
2010-10-13 7:10 ` [PATCH 0/2] move TI_ST driver out of staging Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019222220.892e67e4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.