From: Wu Fengguang <fengguang.wu@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, lkml <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH wq#for-next] workqueue: Clarify that schedule_on_each_cpu is synchronous
Date: Wed, 20 Oct 2010 08:54:00 +0800 [thread overview]
Message-ID: <20101020005400.GB5343@localhost> (raw)
In-Reply-To: <4CBD6276.7070803@kernel.org>
On Tue, Oct 19, 2010 at 05:18:46PM +0800, Tejun Heo wrote:
> The documentation for schedule_on_each_cpu() states that it calls a
> function on each online CPU from keventd. This can easily be
> interpreted as an asyncronous call because the description does not
> mention that flush_work is called. Clarify that it is synchronous.
>
> tj: rephrased a bit
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Nice comment!
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
prev parent reply other threads:[~2010-10-20 0:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 15:25 [PATCH v2.6.36-rc7] memory_hotplug: drop spurious calls to flush_scheduled_work() Tejun Heo
2010-10-18 0:01 ` KAMEZAWA Hiroyuki
2010-10-18 5:03 ` Tejun Heo
2010-10-18 23:58 ` KAMEZAWA Hiroyuki
2010-10-19 9:19 ` Tejun Heo
2010-10-18 5:23 ` Minchan Kim
2010-10-18 9:44 ` Mel Gorman
2010-10-19 4:38 ` KOSAKI Motohiro
2010-10-19 9:18 ` [PATCH wq#for-next] workqueue: Clarify that schedule_on_each_cpu is synchronous Tejun Heo
2010-10-20 0:20 ` KAMEZAWA Hiroyuki
2010-10-20 0:54 ` Wu Fengguang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020005400.GB5343@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.