From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: remove dependency of platform code on CLOCK_TICK_RATE / LATCH defines
Date: Wed, 20 Oct 2010 11:12:05 +0200 [thread overview]
Message-ID: <20101020091205.GK28166@pengutronix.de> (raw)
In-Reply-To: <20101020045121.GX12979@mail.wantstofly.org>
On Wed, Oct 20, 2010 at 06:51:21AM +0200, Lennert Buytenhek wrote:
> One of the things preventing building an ARM multiplatform kernel
> image is the fact that CLOCK_TICK_RATE (and as a consequence, LATCH)
> is defined differently for each platform.
>
> CLOCK_TICK_RATE is mostly unused beyond some usage in the various
> ARM platform support code directories themselves (and a couple of
> bogus uses elsewhere, such as in drivers/input/joystick/analog.c).
>
> Therefore, for those ARM platforms that use their own definition
> of CLOCK_TICK_RATE (for example, in their timer setup code), copy
> the definition of CLOCK_TICK_RATE into the platform code, renaming
> it to TICK_RATE in the process.
>
> Also, for those ARM platforms that use the LATCH define (which is
> derived from CLOCK_TICK_RATE), give them a private definition, named
> TIMER_LATCH, based on the now locally defined TICK_RATE.
>
> This gets rid of platform code dependencies on mach/timex.h's
> CLOCK_TICK_RATE definition, and allows killing all mach/timex.h in
> a subsequent patch.
>
> Signed-off-by: Lennert Buytenhek <buytenh@secretlab.ca>
> ---
> arch/arm/common/time-acorn.c | 15 +++++++++------
> arch/arm/mach-aaec2000/core.c | 9 ++++++---
> arch/arm/mach-at91/at91rm9200_time.c | 8 +++++---
> arch/arm/mach-at91/at91x40.c | 3 ++-
ah, this seems to handle the problem I just pointed out for a later
patch in this series. Maybe you can thread your patches next time?
(E.g. by using git send-email)
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-10-20 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 4:51 [PATCH 1/5] ARM: remove dependency of platform code on CLOCK_TICK_RATE / LATCH defines Lennert Buytenhek
2010-10-20 9:12 ` Uwe Kleine-König [this message]
2010-10-20 18:24 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020091205.GK28166@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.