From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/6] input: Add support for VIA VT8500 and compatibles in i8042 Date: Wed, 20 Oct 2010 14:15:07 -0700 Message-ID: <201010201415.09535.dmitry.torokhov@gmail.com> References: <1287608139-21354-1-git-send-email-alchark@gmail.com> <1287608139-21354-3-git-send-email-alchark@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:44450 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128Ab0JTVPi (ORCPT ); Wed, 20 Oct 2010 17:15:38 -0400 In-Reply-To: <1287608139-21354-3-git-send-email-alchark@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alexey Charkov Cc: vt8500-wm8505-linux-kernel@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday, October 20, 2010 01:55:35 pm Alexey Charkov wrote: > VIA and WonderMedia Systems-on-Chip feature a standard i8042-compatible > keyboard and mouse controller. This adds necessary glue to enable use > of the standard driver with these systems. > > Signed-off-by: Alexey Charkov > --- > > Please review and state whether this could be acceptable for a merge > to mainline in the coming 2.6.37 window. If possible, I would deeply > appreciate a merge to a relevant git tree for integration prior to > asking Linus to pull the changes. I could rebase the code if needed, > currently this is against Linus' master branch. > > This patch relies on the basic architecture support for VT8500/WM8505 > to be in place, as introduced by PATCH 1/6 in this series. What tree this code will be coming through through? > + > +static inline int i8042_platform_init(void) > +{ > + i8042_reset = 1; = true; - it's a boolean. > + regbase = ioremap(VT8500_PS2_BASE, SZ_1K); Error handling? Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Wed, 20 Oct 2010 14:15:07 -0700 Subject: [PATCH 3/6] input: Add support for VIA VT8500 and compatibles in i8042 In-Reply-To: <1287608139-21354-3-git-send-email-alchark@gmail.com> References: <1287608139-21354-1-git-send-email-alchark@gmail.com> <1287608139-21354-3-git-send-email-alchark@gmail.com> Message-ID: <201010201415.09535.dmitry.torokhov@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday, October 20, 2010 01:55:35 pm Alexey Charkov wrote: > VIA and WonderMedia Systems-on-Chip feature a standard i8042-compatible > keyboard and mouse controller. This adds necessary glue to enable use > of the standard driver with these systems. > > Signed-off-by: Alexey Charkov > --- > > Please review and state whether this could be acceptable for a merge > to mainline in the coming 2.6.37 window. If possible, I would deeply > appreciate a merge to a relevant git tree for integration prior to > asking Linus to pull the changes. I could rebase the code if needed, > currently this is against Linus' master branch. > > This patch relies on the basic architecture support for VT8500/WM8505 > to be in place, as introduced by PATCH 1/6 in this series. What tree this code will be coming through through? > + > +static inline int i8042_platform_init(void) > +{ > + i8042_reset = 1; = true; - it's a boolean. > + regbase = ioremap(VT8500_PS2_BASE, SZ_1K); Error handling? Thanks. -- Dmitry