From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631Ab0JTRUp (ORCPT ); Wed, 20 Oct 2010 13:20:45 -0400 Received: from alerce.vps.bitfolk.com ([212.13.194.134]:3699 "EHLO alerce.vps.bitfolk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530Ab0JTRUo (ORCPT ); Wed, 20 Oct 2010 13:20:44 -0400 Date: Wed, 20 Oct 2010 14:20:18 -0300 From: Leandro Lucarella To: Neil Horman Cc: David Miller , paul.gortmaker@windriver.com, jon.maloy@ericsson.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: Re: Linux 2.6.35/TIPC 2.0 ABI breaking changes Message-ID: <20101020172018.GN8781@llucax.com.ar> References: <4CBCD429.8090306@windriver.com> <20101018234547.GA5703@hmsreliant.think-freely.org> <20101019021657.GZ8781@llucax.com.ar> <20101019.011649.71113115.davem@davemloft.net> <20101019110452.GA14410@hmsreliant.think-freely.org> <20101019131936.GB8781@llucax.com.ar> <20101019201841.GC14410@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20101019201841.GC14410@hmsreliant.think-freely.org> X-Paranoid: Just because you're paranoid, don't mean they're not after you. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Neil Horman, el 19 de octubre a las 16:18 me escribiste: > Heres what I have so far. Dave as a heads up please don't apply this > yet. I'd like to go over it a bit more and be sure of the implications here > before I post it for inclusion officially. I wanted Leandro to have a copy > though so he could confirm functionality for us. Leandro, This patch lets me > pass the tipc test code for TIPC 1.6 that you posted earlier this morning. If > you could confirm that it works for you that would be grand. While your doing > that, I want to read over the spec for TIPC and make sure that I'm not breaking > anything new with this patch. I tried the patch (swapping the values of TIPC_SUB_SERVICE and TIPC_SUB_PORTS) based on 2.6.35.4 and it didn't worked. dmesg sais: NOT Swapping endianess in subscr_subscribe NOT Swapping endianess in subscr_subscribe TIPC: Subscription rejected, illegal request I tried with a binary compiled with an older tipc.h header, I didn't tried to recompile it using the new tipc.h (on purpose as the thing that should be fixed is backwards compatibility). I've read the TIPC 2.0 specification[1] a little more, and as I see, the subscription messages are not supposed to go through the wire[2]. 8. Topology Service TIPC provides a message-based mechanism for an application to learn about the port names that are visible to its node. This is achieved by communicating with a Topology Service that has knowledge of the contents of the node's name table. So, if the idea is to comply with TIPC 2.0, the topology service should accept the new TIPC_SUB_SERVICE and TIPC_SUB_PORTS values (0 and 1 in NBO respectively), and all the fields in the subscr struct should be filled in NBO too. However, if the idea is to keep backwards compatibility too, HBO should be accepted as well as the old TIPC_SUB_SERVICE and TIPC_SUB_PORTS values (2 and 1 in HBO respectively). The real problem is, we can't figure out the endianess of the subscr struct because 0x0 is a valid filter in TIPC 2.0. The only solution I see is to change the TIPC 2.0 specification (which is a "work-in-progress") to make the topology service use the port name {2,2}, leaving {1,1} for backwards compatibility. Then add the constants TIPC_SUB_SERVICE2 (0) and TIPC_TOP_SRV2 (2), or similar, to use the TIPC 2.0 interface and leave TIPC_SUB_SERVICE and TIPC_TOP_SRV for the TIPC 1.x interface. Another option is to change the TIPC 2.0 specification to use the old format (use HBO in subscriptions and keep TIPC_SUB_SERVICE as a separate flag with value 2) and forget about all this. After all, I can't see what advantages gives having to change the BO for internal messages between the applications and the stack. [1] http://tipc.sourceforge.net/doc/draft-spec-tipc-06.html [2] http://tipc.sourceforge.net/doc/draft-spec-tipc-06.html#anchor92 -- Leandro Lucarella (AKA luca) http://llucax.com.ar/ ---------------------------------------------------------------------- GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145 104C 949E BFB6 5F5A 8D05) ---------------------------------------------------------------------- CARANCHO OBNUBILADO APARECE EN PARQUE CHACABUCO! -- Crónica TV From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leandro Lucarella Subject: Re: Linux 2.6.35/TIPC 2.0 ABI breaking changes Date: Wed, 20 Oct 2010 14:20:18 -0300 Message-ID: <20101020172018.GN8781@llucax.com.ar> References: <4CBCD429.8090306@windriver.com> <20101018234547.GA5703@hmsreliant.think-freely.org> <20101019021657.GZ8781@llucax.com.ar> <20101019.011649.71113115.davem@davemloft.net> <20101019110452.GA14410@hmsreliant.think-freely.org> <20101019131936.GB8781@llucax.com.ar> <20101019201841.GC14410@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: jon.maloy@ericsson.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, David Miller To: Neil Horman Return-path: Content-Disposition: inline In-Reply-To: <20101019201841.GC14410@hmsreliant.think-freely.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tipc-discussion-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org TmVpbCBIb3JtYW4sIGVsIDE5IGRlIG9jdHVicmUgYSBsYXMgMTY6MTggbWUgZXNjcmliaXN0ZToK PiAJSGVyZXMgd2hhdCBJIGhhdmUgc28gZmFyLiAgRGF2ZSBhcyBhIGhlYWRzIHVwIHBsZWFzZSBk b24ndCBhcHBseSB0aGlzCj4geWV0LiAgSSdkIGxpa2UgdG8gZ28gb3ZlciBpdCBhIGJpdCBtb3Jl IGFuZCBiZSBzdXJlIG9mIHRoZSBpbXBsaWNhdGlvbnMgaGVyZQo+IGJlZm9yZSBJIHBvc3QgaXQg Zm9yIGluY2x1c2lvbiBvZmZpY2lhbGx5LiAgSSB3YW50ZWQgTGVhbmRybyB0byBoYXZlIGEgY29w eQo+IHRob3VnaCBzbyBoZSBjb3VsZCBjb25maXJtIGZ1bmN0aW9uYWxpdHkgZm9yIHVzLiAgTGVh bmRybywgVGhpcyBwYXRjaCBsZXRzIG1lCj4gcGFzcyB0aGUgdGlwYyB0ZXN0IGNvZGUgZm9yIFRJ UEMgMS42IHRoYXQgeW91IHBvc3RlZCBlYXJsaWVyIHRoaXMgbW9ybmluZy4gIElmCj4geW91IGNv dWxkIGNvbmZpcm0gdGhhdCBpdCB3b3JrcyBmb3IgeW91IHRoYXQgd291bGQgYmUgZ3JhbmQuICBX aGlsZSB5b3VyIGRvaW5nCj4gdGhhdCwgSSB3YW50IHRvIHJlYWQgb3ZlciB0aGUgc3BlYyBmb3Ig VElQQyBhbmQgbWFrZSBzdXJlIHRoYXQgSSdtIG5vdCBicmVha2luZwo+IGFueXRoaW5nIG5ldyB3 aXRoIHRoaXMgcGF0Y2guCgpJIHRyaWVkIHRoZSBwYXRjaCAoc3dhcHBpbmcgdGhlIHZhbHVlcyBv ZiBUSVBDX1NVQl9TRVJWSUNFIGFuZApUSVBDX1NVQl9QT1JUUykgYmFzZWQgb24gMi42LjM1LjQg YW5kIGl0IGRpZG4ndCB3b3JrZWQuIGRtZXNnIHNhaXM6Ck5PVCBTd2FwcGluZyBlbmRpYW5lc3Mg aW4gc3Vic2NyX3N1YnNjcmliZQpOT1QgU3dhcHBpbmcgZW5kaWFuZXNzIGluIHN1YnNjcl9zdWJz Y3JpYmUKVElQQzogU3Vic2NyaXB0aW9uIHJlamVjdGVkLCBpbGxlZ2FsIHJlcXVlc3QKCkkgdHJp ZWQgd2l0aCBhIGJpbmFyeSBjb21waWxlZCB3aXRoIGFuIG9sZGVyIHRpcGMuaCBoZWFkZXIsIEkg ZGlkbid0CnRyaWVkIHRvIHJlY29tcGlsZSBpdCB1c2luZyB0aGUgbmV3IHRpcGMuaCAob24gcHVy cG9zZSBhcyB0aGUgdGhpbmcgdGhhdApzaG91bGQgYmUgZml4ZWQgaXMgYmFja3dhcmRzIGNvbXBh dGliaWxpdHkpLgoKSSd2ZSByZWFkIHRoZSBUSVBDIDIuMCBzcGVjaWZpY2F0aW9uWzFdIGEgbGl0 dGxlIG1vcmUsIGFuZCBhcyBJIHNlZSwgdGhlCnN1YnNjcmlwdGlvbiBtZXNzYWdlcyBhcmUgbm90 IHN1cHBvc2VkIHRvIGdvIHRocm91Z2ggdGhlIHdpcmVbMl0uCgoJOC4gIFRvcG9sb2d5IFNlcnZp Y2UKCglUSVBDIHByb3ZpZGVzIGEgbWVzc2FnZS1iYXNlZCBtZWNoYW5pc20gZm9yIGFuIGFwcGxp Y2F0aW9uIHRvCglsZWFybiBhYm91dCB0aGUgcG9ydCBuYW1lcyB0aGF0IGFyZSB2aXNpYmxlIHRv IGl0cyBub2RlLiBUaGlzIGlzCglhY2hpZXZlZCBieSBjb21tdW5pY2F0aW5nIHdpdGggYSBUb3Bv bG9neSBTZXJ2aWNlIHRoYXQgaGFzCglrbm93bGVkZ2Ugb2YgdGhlIGNvbnRlbnRzIG9mIHRoZSBu b2RlJ3MgbmFtZSB0YWJsZS4KClNvLCBpZiB0aGUgaWRlYSBpcyB0byBjb21wbHkgd2l0aCBUSVBD IDIuMCwgdGhlIHRvcG9sb2d5IHNlcnZpY2Ugc2hvdWxkCmFjY2VwdCB0aGUgbmV3IFRJUENfU1VC X1NFUlZJQ0UgYW5kIFRJUENfU1VCX1BPUlRTIHZhbHVlcyAoMCBhbmQKMSBpbiBOQk8gcmVzcGVj dGl2ZWx5KSwgYW5kIGFsbCB0aGUgZmllbGRzIGluIHRoZSBzdWJzY3Igc3RydWN0IHNob3VsZApi ZSBmaWxsZWQgaW4gTkJPIHRvby4KCkhvd2V2ZXIsIGlmIHRoZSBpZGVhIGlzIHRvIGtlZXAgYmFj a3dhcmRzIGNvbXBhdGliaWxpdHkgdG9vLCBIQk8gc2hvdWxkCmJlIGFjY2VwdGVkIGFzIHdlbGwg YXMgdGhlIG9sZCBUSVBDX1NVQl9TRVJWSUNFIGFuZCBUSVBDX1NVQl9QT1JUUwp2YWx1ZXMgKDIg YW5kIDEgaW4gSEJPIHJlc3BlY3RpdmVseSkuCgpUaGUgcmVhbCBwcm9ibGVtIGlzLCB3ZSBjYW4n dCBmaWd1cmUgb3V0IHRoZSBlbmRpYW5lc3Mgb2YgdGhlIHN1YnNjcgpzdHJ1Y3QgYmVjYXVzZSAw eDAgaXMgYSB2YWxpZCBmaWx0ZXIgaW4gVElQQyAyLjAuCgpUaGUgb25seSBzb2x1dGlvbiBJIHNl ZSBpcyB0byBjaGFuZ2UgdGhlIFRJUEMgMi4wIHNwZWNpZmljYXRpb24gKHdoaWNoCmlzIGEgIndv cmstaW4tcHJvZ3Jlc3MiKSB0byBtYWtlIHRoZSB0b3BvbG9neSBzZXJ2aWNlIHVzZSB0aGUgcG9y dCBuYW1lCnsyLDJ9LCBsZWF2aW5nIHsxLDF9IGZvciBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eS4g VGhlbiBhZGQgdGhlIGNvbnN0YW50cwpUSVBDX1NVQl9TRVJWSUNFMiAoMCkgYW5kIFRJUENfVE9Q X1NSVjIgKDIpLCBvciBzaW1pbGFyLCB0byB1c2UgdGhlIFRJUEMKMi4wIGludGVyZmFjZSBhbmQg bGVhdmUgVElQQ19TVUJfU0VSVklDRSBhbmQgVElQQ19UT1BfU1JWIGZvciB0aGUgVElQQwoxLngg aW50ZXJmYWNlLgoKQW5vdGhlciBvcHRpb24gaXMgdG8gY2hhbmdlIHRoZSBUSVBDIDIuMCBzcGVj aWZpY2F0aW9uIHRvIHVzZSB0aGUgb2xkCmZvcm1hdCAodXNlIEhCTyBpbiBzdWJzY3JpcHRpb25z IGFuZCBrZWVwIFRJUENfU1VCX1NFUlZJQ0UgYXMgYSBzZXBhcmF0ZQpmbGFnIHdpdGggdmFsdWUg MikgYW5kIGZvcmdldCBhYm91dCBhbGwgdGhpcy4gQWZ0ZXIgYWxsLCBJIGNhbid0IHNlZQp3aGF0 IGFkdmFudGFnZXMgZ2l2ZXMgaGF2aW5nIHRvIGNoYW5nZSB0aGUgQk8gZm9yIGludGVybmFsIG1l c3NhZ2VzCmJldHdlZW4gdGhlIGFwcGxpY2F0aW9ucyBhbmQgdGhlIHN0YWNrLgoKWzFdIGh0dHA6 Ly90aXBjLnNvdXJjZWZvcmdlLm5ldC9kb2MvZHJhZnQtc3BlYy10aXBjLTA2Lmh0bWwKWzJdIGh0 dHA6Ly90aXBjLnNvdXJjZWZvcmdlLm5ldC9kb2MvZHJhZnQtc3BlYy10aXBjLTA2Lmh0bWwjYW5j aG9yOTIKCi0tIApMZWFuZHJvIEx1Y2FyZWxsYSAoQUtBIGx1Y2EpICAgICAgICAgICAgICAgICAg ICAgaHR0cDovL2xsdWNheC5jb20uYXIvCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KR1BHIEtleTogNUY1QThEMDUg KEY4Q0QgRjlBNyBCRjAwIDU0MzEgNDE0NSAgMTA0QyA5NDlFIEJGQjYgNUY1QSA4RDA1KQotLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCkNBUkFOQ0hPIE9CTlVCSUxBRE8gQVBBUkVDRSBFTiBQQVJRVUUgQ0hBQ0FCVUNP IQoJLS0gQ3LDs25pY2EgVFYKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpOb2tpYSBhbmQgQVQmVCBw cmVzZW50IHRoZSAyMDEwIENhbGxpbmcgQWxsIElubm92YXRvcnMtTm9ydGggQW1lcmljYSBjb250 ZXN0CkNyZWF0ZSBuZXcgYXBwcyAmIGdhbWVzIGZvciB0aGUgTm9raWEgTjggZm9yIGNvbnN1bWVy cyBpbiAgVS5TLiBhbmQgQ2FuYWRhCiQxMCBtaWxsaW9uIHRvdGFsIGluIHByaXplcyAtICQ0TSBj YXNoLCA1MDAgZGV2aWNlcywgbmVhcmx5ICQ2TSBpbiBtYXJrZXRpbmcKRGV2ZWxvcCB3aXRoIE5v a2lhIFF0IFNESywgV2ViIFJ1bnRpbWUsIG9yIEphdmEgYW5kIFB1Ymxpc2ggdG8gT3ZpIFN0b3Jl IApodHRwOi8vcC5zZi5uZXQvc2Z1L25va2lhLWRldjJkZXYKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KdGlwYy1kaXNjdXNzaW9uIG1haWxpbmcgbGlzdAp0 aXBjLWRpc2N1c3Npb25AbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNl Zm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL3RpcGMtZGlzY3Vzc2lvbgo=