From: Alasdair G Kergon <agk@redhat.com>
To: Milan Broz <mbroz@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Mike Snitzer <snitzer@redhat.com>,
linux-kernel@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
pedrib@gmail.com
Subject: Re: [dm-devel] [PATCH] DM-CRYPT: Scale to multiple CPUs v3
Date: Wed, 20 Oct 2010 18:32:31 +0100 [thread overview]
Message-ID: <20101020173231.GP3935@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <4CBEFABC.3030400@redhat.com>
On Wed, Oct 20, 2010 at 04:20:44PM +0200, Milan Broz wrote:
> this patch introduces apparent regressions in async crypto mode.
OK, thanks for performing those tests.
This patch is stalled until these problems are understood properly and
solutions are proposed. I was prepared to overlook the regression in
stacked 'async' provided there was an inline FIXME explaining clearly
how to fix it in future should we need to, but I can't support a patch that
apparently breaks stacked sync encryption.
One solution might be to make the proposed changes only for non-stacked
configurations and leave stacks to work as they do today - either
detecting that automatically or having userspace supply a target
parameter to say whether or not to turn it on. (For that, would need
tests to show a stack of many layers where only one is a crypt target
continues to work after the change.)
Alasdair
next prev parent reply other threads:[~2010-10-20 17:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 11:59 [PATCH] DM-CRYPT: Scale to multiple CPUs v3 Andi Kleen
2010-10-10 12:38 ` [dm-devel] " Milan Broz
2010-10-10 12:53 ` Milan Broz
2010-10-10 13:09 ` Andi Kleen
2010-10-10 13:08 ` Andi Kleen
2010-10-10 15:34 ` Milan Broz
2010-10-10 16:06 ` Andi Kleen
2010-10-10 16:22 ` Mike Snitzer
2010-10-10 16:41 ` Milan Broz
2010-10-10 17:07 ` Mike Snitzer
2010-10-10 18:56 ` [PATCH] Fix double free and use generic private pointer in per-cpu struct Milan Broz
2010-10-14 19:26 ` [dm-devel] " Milan Broz
2010-10-20 14:20 ` [dm-devel] [PATCH] DM-CRYPT: Scale to multiple CPUs v3 Milan Broz
2010-10-20 17:32 ` Alasdair G Kergon [this message]
2010-10-10 17:01 ` Alasdair G Kergon
2010-10-10 17:44 ` Andi Kleen
2010-10-10 17:44 ` Andi Kleen
2010-10-10 18:17 ` [dm-devel] " Alasdair G Kergon
2010-10-10 18:48 ` Alasdair G Kergon
2010-10-10 18:48 ` [dm-devel] " Alasdair G Kergon
2010-10-10 18:51 ` Andi Kleen
2010-10-10 18:51 ` Andi Kleen
2010-10-10 19:07 ` Alasdair G Kergon
2010-10-10 19:16 ` Andi Kleen
2010-10-10 19:16 ` Andi Kleen
2010-10-10 19:31 ` Milan Broz
2010-10-10 20:20 ` Andi Kleen
2010-10-11 9:32 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020173231.GP3935@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=pedrib@gmail.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.