From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] ide: Handle flush failure
Date: Thu, 21 Oct 2010 07:21:32 +0200 [thread overview]
Message-ID: <20101021052132.GC15430@lst.de> (raw)
In-Reply-To: <1287500932-7366-3-git-send-email-kwolf@redhat.com>
On Tue, Oct 19, 2010 at 05:08:52PM +0200, Kevin Wolf wrote:
> Instead of always assuming success for bdrv_aio_flush, actually do something
> with the error. This respects the werror option and accordingly ignores the
> error, reports it to the guest or stops the VM and retries after cont.
>
> Ignoring the error is trivial, obviously. For stopping the VM and retrying
> later old code can be reused, but we need to introduce a new status for "retry
> a flush". For reporting to the guest, fortunately the same action is required
> as for a failed read/write (status = DRDY | ERR, error = ABRT), so this code
> can be reused as well.
ACK
prev parent reply other threads:[~2010-10-21 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 15:08 [Qemu-devel] [PATCH 0/2] ide: Handle bdrv_aio_flush errors Kevin Wolf
2010-10-19 15:08 ` [Qemu-devel] [PATCH 1/2] ide: Factor ide_flush_cache out Kevin Wolf
2010-10-21 5:21 ` Christoph Hellwig
2010-10-19 15:08 ` [Qemu-devel] [PATCH 2/2] ide: Handle flush failure Kevin Wolf
2010-10-21 5:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021052132.GC15430@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.