Re: [PATCH 1/2] iwlwifi: fix set_tx_power vs scan

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Thu, Oct 14, 2010 at 10:32:05AM +0200, Stanislaw Gruszka wrote:
> > Looks good, the only thing is if priv->tx_power_user_lmt ==
> > priv->tx_power_next, we don't even have to call set_tx_power, but I
> > guess calling it won't hurt, so its your decision check or not.
> 
> I'll will call iwl_set_tx_power( ... , false); what seems to be right
> thing to do.

Set tx power have to be forces. Without that I get  

iwlagn 0000:40:00.0: low ack count detected, restart firmware
iwlagn 0000:40:00.0: On demand firmware reload
iwlagn 0000:40:00.0: Stopping AGG while state not ON or starting
iwlagn 0000:40:00.0: queue number out of range: 0, must be 10 to 19
iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0
iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 1
iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0
iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0
iwlagn 0000:40:00.0: iwlagn_tx_agg_start on ra = 00:23:69:35:d1:3f tid = 0
iwlagn 0000:40:00.0: low ack count detected, restart firmware
iwlagn 0000:40:00.0: On demand firmware reload
iwlagn 0000:40:00.0: Stopping AGG while state not ON or starting
iwlagn 0000:40:00.0: queue number out of range: 0, must be 10 to 19
iwlagn 0000:40:00.0: iwlagn_tx_agg_start on ra = 00:23:69:35:d1:3f tid = 0
iwlagn 0000:40:00.0: low ack count detected, restart firmware
iwlagn 0000:40:00.0: On demand firmware reload
iwlagn 0000:40:00.0: Stopping AGG while state not ON or starting
iwlagn 0000:40:00.0: queue number out of range: 0, must be 10 to 19
iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 4
iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0

on 5300 and device was unusable in general. Hence I will only comment
that forcing send tx power after scan is needed.

Stanislaw