All of lore.kernel.org
 help / color / mirror / Atom feed
From: =?unknown-8bit?q?Beno=C3=AEt?= Monin <benoit.monin@gmx.fr>
To: ofono@ofono.org
Subject: [PATCH] common : bring back some details about technology
Date: Thu, 21 Oct 2010 16:07:20 +0200	[thread overview]
Message-ID: <20101021140720.178830@gmx.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

Our application require some more details about network technology
in use. This patch might be a bit controversial because commit
1e783b3 actively simplified the technology field.

Maybe adding a 'Generation' field ('2G', '2.5G', '3G'...) would
be  more end-user friendly ?
---
 src/common.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/common.c b/src/common.c
index b5b9a6f..d571d81 100644
--- a/src/common.c
+++ b/src/common.c
@@ -655,15 +655,15 @@ const char *registration_tech_to_string(int tech)
        case ACCESS_TECHNOLOGY_GSM:
                return "gsm";
        case ACCESS_TECHNOLOGY_GSM_COMPACT:
-               return "gsm";
+               return "gprs";
        case ACCESS_TECHNOLOGY_UTRAN:
                return "umts";
        case ACCESS_TECHNOLOGY_GSM_EGPRS:
                return "edge";
        case ACCESS_TECHNOLOGY_UTRAN_HSDPA:
-               return "hspa";
+               return "hsdpa";
        case ACCESS_TECHNOLOGY_UTRAN_HSUPA:
-               return "hspa";
+               return "hsupa";
        case ACCESS_TECHNOLOGY_UTRAN_HSDPA_HSUPA:
                return "hspa";
        case ACCESS_TECHNOLOGY_EUTRAN:
--

             reply	other threads:[~2010-10-21 14:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 14:07 =?unknown-8bit?q?Beno=C3=AEt?= Monin [this message]
2010-10-22 13:29 ` [PATCH] common : bring back some details about technology Aki Niemi
  -- strict thread matches above, loose matches on Subject: below --
2010-10-22 14:01 =?unknown-8bit?q?Beno=C3=AEt?= Monin
2010-10-22 14:37 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101021140720.178830@gmx.com \
    --to=benoit.monin@gmx.fr \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.