From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: rklein@nvidia.com, Anton Vorontsov <cbouatmailru@gmail.com>,
achew@nvidia.com, olof@lixom.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] POWER: Add gpio charger driver
Date: Thu, 21 Oct 2010 09:00:09 -0700 [thread overview]
Message-ID: <20101021160008.GD9447@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1287676501-23254-1-git-send-email-lars@metafoo.de>
On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:
> + irq = gpio_to_irq(pdata->gpio);
> + if (irq > 0) {
> + ret = request_irq(irq, gpio_charger_irq,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> + dev_name(&pdev->dev), charger);
> + if (ret)
> + dev_warn(&pdev->dev, "Failed to request irq: %d\n", ret);
It would be good to handle IRQs that can sleep (like those on I2C GPIO
expanders) here - either always use a threaded IRQ handler (probably
won't hurt here) or use one if the IRQ can sleep.
next prev parent reply other threads:[~2010-10-21 16:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 0:56 [PATCH v2] power: bq24617: Adding initial charger support rklein
2010-10-21 12:20 ` Lars-Peter Clausen
2010-10-21 12:25 ` [PATCH] POWER: Add gpio chager driver Lars-Peter Clausen
2010-10-21 12:43 ` Piotr Hosowicz
2010-10-21 14:53 ` Lars-Peter Clausen
2010-10-21 14:14 ` Anton Vorontsov
2010-10-21 14:52 ` Lars-Peter Clausen
2010-10-21 15:05 ` Anton Vorontsov
2010-10-21 17:22 ` Rhyland Klein
2010-10-21 15:55 ` [PATCH v2] POWER: Add gpio charger driver Lars-Peter Clausen
2010-10-21 16:00 ` Mark Brown [this message]
2010-10-21 16:16 ` Lars-Peter Clausen
2010-10-21 16:19 ` Mark Brown
2010-10-21 16:26 ` Anton Vorontsov
2010-10-21 17:47 ` Lars-Peter Clausen
2010-10-22 21:41 ` Rhyland Klein
2010-10-28 21:17 ` Rhyland Klein
2010-11-04 17:47 ` Anton Vorontsov
2010-11-11 0:53 ` Rhyland Klein
2010-11-11 1:33 ` Lars-Peter Clausen
2010-11-11 1:46 ` Rhyland Klein
2010-11-17 1:37 ` Rhyland Klein
2010-11-18 14:05 ` Anton Vorontsov
2010-11-18 14:30 ` Lars-Peter Clausen
2010-11-18 14:42 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021160008.GD9447@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=achew@nvidia.com \
--cc=cbouatmailru@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.