From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: alsa-devel@alsa-project.org, Saeed Bishara <saeed@marvell.com>,
Martin Michlmayr <tbm@cyrius.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [patch v3 1/2] ASoC: add support for alc562[123] codecs
Date: Thu, 21 Oct 2010 09:28:09 -0700 [thread overview]
Message-ID: <20101021162809.GG9447@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20101021104846.183611804@rtp-net.org>
On Thu, Oct 21, 2010 at 12:44:37PM +0200, Arnaud Patard wrote:
> +static void alc5623_work(struct work_struct *work)
> +{
> + struct snd_soc_codec *codec =
> + container_of(work, struct snd_soc_codec, delayed_work.work);
> + alc5623_set_bias_level(codec, codec->bias_level);
> +}
Like I said when reviewing the last version please remove this and do
the ramping of VMID in line where it's required instead - the framework
should support this well enough now. Indeed...
> + /* charge alc5623 caps */
> + if (codec->suspend_bias_level == SND_SOC_BIAS_ON) {
> + alc5623_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
> + codec->bias_level = SND_SOC_BIAS_ON;
> + alc5623_set_bias_level(codec, codec->bias_level);
...it looks like it may just be that the delayed work and associated
stuff is left over and can be removed entirely.
next prev parent reply other threads:[~2010-10-21 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 10:44 [patch v3 0/2] ASoC: alc562[123] / HP t5325 support - try 3 Arnaud Patard
2010-10-21 10:44 ` [patch v3 1/2] ASoC: add support for alc562[123] codecs Arnaud Patard
2010-10-21 16:28 ` Mark Brown [this message]
2010-10-21 10:44 ` [patch v3 2/2] ASoC: kirkwood: Add audio support to hp t5325 thin clients Arnaud Patard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021162809.GG9447@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=lrg@slimlogic.co.uk \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.