From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH] xfstests: remove dead code in test 062
Date: Thu, 21 Oct 2010 16:07:12 -0400 [thread overview]
Message-ID: <20101021200712.GA30128@infradead.org> (raw)
The _linux_attr_calls function is never called, remove it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/062
===================================================================
--- xfstests-dev.orig/062 2010-10-21 19:57:24.000000000 +0000
+++ xfstests-dev/062 2010-10-21 19:58:34.000000000 +0000
@@ -51,47 +51,6 @@ _filter_scratch()
sed -e "s,$SCRATCH_MNT,SCRATCH_MNT,g"
}
-_linux_attr_calls()
-{
- echo "*** set/get one initially empty attribute"
- setfattr -h -n $nsp.name $SCRATCH_MNT/$inode
- getfattr -m $nsp $SCRATCH_MNT/$inode
-
- echo "*** overwrite empty, set several new attributes"
- setfattr -h -n $nsp.name -v 0xbabe $SCRATCH_MNT/$inode
- setfattr -h -n $nsp.name2 -v 0xdeadbeef $SCRATCH_MNT/$inode
- setfattr -h -n $nsp.name3 -v 0xdeface $SCRATCH_MNT/$inode
-
- echo "*** fetch several attribute names and values (hex)"
- getfattr -m $nsp -e hex $SCRATCH_MNT/$inode
-
- echo "*** fetch several attribute names and values (base64)"
- getfattr -m $nsp -e base64 $SCRATCH_MNT/$inode
-
- echo "*** shrink value of an existing attribute"
- setfattr -h -n $nsp.name2 -v 0xdeaf $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex $SCRATCH_MNT/$inode
-
- echo "*** grow value of existing attribute"
- setfattr -h -n $nsp.name2 -v 0xdecade $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex $SCRATCH_MNT/$inode
-
- echo "*** set an empty value for second attribute"
- setfattr -h -n $nsp.name2 $SCRATCH_MNT/$inode
- getfattr -m $nsp -n $nsp.name2 $SCRATCH_MNT/$inode
-
- echo "*** overwrite empty value"
- setfattr -h -n $nsp.name2 -v 0xcafe $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex -n $nsp.name2 $SCRATCH_MNT/$inode
-
- echo "*** remove attribute"
- setfattr -h -x $nsp.name2 $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex -n $nsp.name2 $SCRATCH_MNT/$inode
-
- echo "*** final list (strings, type=$inode, nsp=$nsp)"
- getfattr -m '.' -e hex $SCRATCH_MNT/$inode
-}
-
getfattr()
{
$GETFATTR_PROG --absolute-names -dh $@ 2>&1 | _filter_scratch
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-10-21 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 20:07 Christoph Hellwig [this message]
2010-10-21 21:25 ` [PATCH] xfstests: remove dead code in test 062 Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021200712.GA30128@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.