From: Camille Moncelier <moncelier@devlife.org>
To: git@vger.kernel.org
Subject: Re: [PATCH 2/3] merge-recursive: Small code cleanup
Date: Thu, 21 Oct 2010 21:43:15 +0200 [thread overview]
Message-ID: <20101021214315.17c535e1@cortex> (raw)
In-Reply-To: EF9FEAB3A4B7D245B0801936B6EF4A25593A57@azsmsx503.amr.corp.intel.com
On Thu, 9 Sep 2010 13:23:26 -0700
"Schalk, Ken" <ken.schalk@intel.com> wrote:
> >Perhaps you could submit another patch changing your testcase back to
> >using a symlink to make sure someone like me doesn't break your
> >original testcase in the future?
>
> Here's a patch relative to my last one. Rather than restoring the
> previous test, I added it so that platforms with no symlink support
> can still test copy vs. rename and platforms with symlink support can
> also test rename vs. rename/symlink.
Hello, I think I have a test case that seems to be related to this
issue.
mkdir -p repo1
pushd repo1
git init .
mkdir dir1
echo file1 > dir1/file1
ln -s dir1 dir2
git add dir1 dir2
git commit -m "Initial status: dir2 -> dir1"
git checkout -b test1
git checkout -b test2
git co test1
git rm dir2
mkdir dir2
touch file2 > dir2/file1
git add dir2/file1
git commit -m "Removing link: dir1/ and dir2/"
message="New file in test1"
echo $message > new_file_test1
git add new_file_test1
git commit -m "$message"
git co test2
message="New file in test2"
echo $message > new_file_test2
git add new_file_test2
git commit -m "$message"
# Tries to get the last commit (which adds new_file_test1)
# into test2 fails.
git cherry-pick test1
# Would work with: git cherry-pick --strategy=resolve test1
# (using 1.7.3.1)
next prev parent reply other threads:[~2010-10-21 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 16:17 cherry-picking a commit clobbers a file which is a directory in the target commit Nick
2010-09-06 9:50 ` Nick
2010-09-06 15:20 ` Elijah Newren
2010-09-06 20:47 ` [PATCH 0/3] Fix resolvable rename + D/F conflict testcases Elijah Newren
2010-09-06 20:49 ` Elijah Newren
2010-09-06 20:47 ` [PATCH 1/3] t3509: Add rename + D/F conflict testcases that recursive strategy fails Elijah Newren
2010-09-06 20:47 ` [PATCH 2/3] merge-recursive: Small code cleanup Elijah Newren
2010-09-06 21:25 ` Elijah Newren
2010-09-06 23:49 ` Junio C Hamano
2010-09-07 16:23 ` Schalk, Ken
2010-09-08 6:24 ` Elijah Newren
2010-09-09 20:23 ` Schalk, Ken
2010-10-21 19:43 ` Camille Moncelier [this message]
2010-09-06 20:47 ` [PATCH 3/3] merge-recursive: D/F conflicts where was_a_dir/file -> was_a_dir Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021214315.17c535e1@cortex \
--to=moncelier@devlife.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.