From mboxrd@z Thu Jan  1 00:00:00 1970
From: David =?iso-8859-1?Q?H=E4rdeman?= <david@hardeman.nu>
Subject: Re: [PATCH] i915: enable AVI infoframe for intel_hdmi.c
	[v4]
Date: Fri, 22 Oct 2010 00:08:34 +0200
Message-ID: <20101021220834.GA23540@hardeman.nu>
References: <20100924194432.22789.62847.stgit@localhost.localdomain>
	<20101020194541.GC15994@hardeman.nu>
	<b9dded$grr7f7@orsmga002.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from palpatine.hardeman.nu (1-1-12-13a.han.sth.bostream.se
	[82.182.30.168])
	by gabe.freedesktop.org (Postfix) with ESMTP id E68549E76F
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 21 Oct 2010 15:08:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <b9dded$grr7f7@orsmga002.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, jesse.barnes@intel.com
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Oct 21, 2010 at 10:36:33AM +0100, Chris Wilson wrote:
> On Wed, 20 Oct 2010 21:45:41 +0200, David H=E4rdeman <david@hardeman.nu> =
wrote:
> > On Fri, Sep 24, 2010 at 09:44:32PM +0200, David H=E4rdeman wrote:
> > > Two questions still remain:
> > > =

> > > I'm assuming that the sdvo hardware also stores a header ECC byte in
> > > the MSB of the first dword - is this correct?
> > > =

> > > Does the SDVOB and SDVOC handling in intel_hdmi_set_avi_infoframe()
> > > look correct?
> > =

> > Ping...
> =

> Sorry David, I thought I had replied but it never made it to the list.
> =

> I was half waiting if someone would find the answer to your questions. I
> am not certain about the reg -> port conversion either, but if it works
> for you, that is a major step forward.
> =

> More importantly, the patch is missing your signed-off-by, which states
> that the work is yours (or at least you vouchsafe for the originality of
> the work) and you are free to contribute this work to upstream.

I intentionally left out the SOB line because I wanted to have my =

questions answered first. Assuming that I (random guy without access to =

sdvo hw docs) would understand the sdvo avi infoframe programming better =

than the original author of the code (presumably someone at Intel with =

access to said docs) seemed like an unsafe assumption. On the other =

hand, if sdvo breaks, I guess someone will speak up loudly :)
 =

> Just reply adding your 'Signed-off-by' and I'll push the patch to -next.

Signed-off-by: David H=E4rdeman <david@hardeman.nu>

-- =

David H=E4rdeman