From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Harald Welte <laforge@openmoko.org>
Subject: Re: [PATCH] mfd: Fix resource reclaim in pcf50633_remove()
Date: Fri, 22 Oct 2010 00:54:57 +0200 [thread overview]
Message-ID: <20101021225457.GE11685@sortiz-mobl> (raw)
In-Reply-To: <1287565019.7849.2.camel@mola>
Hi Axel,
On Wed, Oct 20, 2010 at 04:56:59PM +0800, Axel Lin wrote:
> Calling sysfs_remove_group() to remove sysfs entries
> and unregister bl_pdev in pcf50633_remove().
patch applied, thanks.
Cheers,
Samuel.
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/pcf50633-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6d4233f..501ce13 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -339,12 +339,14 @@ static int __devexit pcf50633_remove(struct i2c_client *client)
> struct pcf50633 *pcf = i2c_get_clientdata(client);
> int i;
>
> + sysfs_remove_group(&client->dev.kobj, &pcf_attr_group);
> pcf50633_irq_free(pcf);
>
> platform_device_unregister(pcf->input_pdev);
> platform_device_unregister(pcf->rtc_pdev);
> platform_device_unregister(pcf->mbc_pdev);
> platform_device_unregister(pcf->adc_pdev);
> + platform_device_unregister(pcf->bl_pdev);
>
> for (i = 0; i < PCF50633_NUM_REGULATORS; i++)
> platform_device_unregister(pcf->regulator_pdev[i]);
> --
> 1.7.2
>
>
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-10-21 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 8:56 [PATCH] mfd: Fix resource reclaim in pcf50633_remove() Axel Lin
2010-10-20 9:11 ` Harald Welte
2010-10-21 22:54 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021225457.GE11685@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=laforge@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.