From: Rusty Russell <rusty@rustcorp.com.au>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Mike Travis <travis@sgi.com>,
anton@samba.org, linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: Finishing off cpumask...
Date: Fri, 22 Oct 2010 10:32:42 +1030 [thread overview]
Message-ID: <201010221032.42687.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1287652907.3488.64.camel@twins>
On Thu, 21 Oct 2010 07:51:47 pm Peter Zijlstra wrote:
> On Thu, 2010-10-21 at 17:35 +1030, Rusty Russell wrote:
> > The next two turn off and break
> > old-style cpumask uses when CONFIG_CPUMASK_OFFSTACK is set,
>
> Breaking old style for !CONFIG_CPUMASK_OFFSTAK too would be awesome, but
> I guess that's hard to do?
There are four things we could do.
(1) Get rid of the old cpus_ operators (=> cpumask_*). They're just
confusing, and removing them would be a clarity win.
(2) Get rid of cpu_*_map (=> cpu_*_mask). The maps are just wrappers.
(3) Getting rid of cpumask_t (=> struct cpumask) and NR_CPUS
(=> CONFIG_NR_CPUS). These are totally cosmetic.
(4) Getting rid of cpumask_t/struct cpumask (=> cpumask_var_t) is basically
only useful if an arch is thinking about CPUMASK_OFFSTACK, and most
painful.
So, I've changed the CONFIG option which disables (1) and (2); now anyone
will be able to turn it on if they want to test. That might encourage
the per-arch cleanup...
Thanks,
Rusty.
prev parent reply other threads:[~2010-10-22 0:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 7:05 Finishing off cpumask Rusty Russell
2010-10-21 9:21 ` Peter Zijlstra
2010-10-22 0:02 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010221032.42687.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.