From: Kristoffer Ericson <kristoffer.ericson@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v3] Add support for HP Jornada flashrom boards
Date: Fri, 22 Oct 2010 12:34:48 +0200 [thread overview]
Message-ID: <20101022103448.GE994@boggieman> (raw)
In-Reply-To: <20101019214529.9AEFE136320@gemini.denx.de>
On Tue, Oct 19, 2010 at 11:45:29PM +0200, Wolfgang Denk wrote:
> Dear Kristoffer Ericson,
>
> In message <1287178303-17003-1-git-send-email-kristoffer.ericson@gmail.com> you wrote:
> > This patch adds support for the HP Jornada flashboards
> > that were made in 2008. Older flashroms should work if
> > memory registers are adjusted.
> >
> > Signed-off-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> > ---
> > Changes for v2:
> > - Adding myself to MAINTAINERS
> > - Fixing line lengths
> > - Fixing comment style
> > Changes for v3:
> > - setting MACH_TYPE_JORNADA720
> > - CONFIG_SYS_HZ = 1000
> >
> > MAINTAINERS | 4 +
> > board/jornada/Makefile | 53 +++++++++++
> > board/jornada/config.mk | 6 ++
> > board/jornada/jornada.c | 65 ++++++++++++++
> > board/jornada/setup.S | 210 +++++++++++++++++++++++++++++++++++++++++++++
> > board/jornada/u-boot.lds | 58 +++++++++++++
> > boards.cfg | 1 +
> > include/configs/jornada.h | 153 +++++++++++++++++++++++++++++++++
> > 8 files changed, 550 insertions(+), 0 deletions(-)
> > create mode 100644 board/jornada/Makefile
> > create mode 100644 board/jornada/config.mk
> > create mode 100644 board/jornada/jornada.c
> > create mode 100644 board/jornada/setup.S
> > create mode 100644 board/jornada/u-boot.lds
> > create mode 100644 include/configs/jornada.h
>
> Applied, with some modifications:
Thanks, sounds like resonable changes. I believe I
had something in jornada_init() earlier but moved it.
>
> Adpted for TEXT_BASE -> CONFIG_SYS_TEXT_BASE rename.
> Removed now redundant board/jornada/config.mk file.
> Removed unused empty jornada_init() function to silence
> "jornada.c:35: warning: 'jornada_init' defined but not used"
>
> Please check everything is OK for you.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> miracle: an extremely outstanding or unusual event, thing, or
> accomplishment. - Webster's Dictionary
prev parent reply other threads:[~2010-10-22 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 21:31 [U-Boot] [Patch v3] Add support for HP Jornada flashrom boards Kristoffer Ericson
2010-10-19 21:45 ` Wolfgang Denk
2010-10-22 10:34 ` Kristoffer Ericson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022103448.GE994@boggieman \
--to=kristoffer.ericson@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.