From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pca953x: pca953x driver fixes for x86 mrst
Date: Fri, 22 Oct 2010 12:53:06 -0700 [thread overview]
Message-ID: <20101022125306.ace6ca55.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101022124716.19975.12805.stgit@localhost.localdomain>
On Fri, 22 Oct 2010 13:47:47 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> From: Alek Du <alek.du@intel.com>
>
> Our Moorestown platform has two max7315 chips which is covered by
> pca953x i2c gpio driver.
>
> A while ago this driver got updated with nested irq thread support, and it
> broke the compatibity with "request_irq". For example, the gpio_keys.c
> driver can not work with this driver now. This patch fixes the issue by
> switching to generic_handle_irq.
>
> Also fix the irq_base issue: irq_base == 0 is valid, and a "-1" value
> should mean invalid. IRQ 0 is not a valid IRQ, irq_base of 0 is valid.
This sounds like a regression fix. Should it be backported into
-stable?
prev parent reply other threads:[~2010-10-22 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 12:47 [PATCH] pca953x: pca953x driver fixes for x86 mrst Alan Cox
2010-10-22 19:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022125306.ace6ca55.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.