Re: [PATCH 2/2] ASoC: TWL4030: Use usleep_range when appropriate

[Peter Ujfalusi <peter.ujfalusi@nokia.com>]

On Friday 22 October 2010 15:11:21 ext Peter Ujfalusi wrote:
> Change the busy loop delays with usleep_range or msleep calls.

> -	/* wait for offset cancellation to complete */
> +	/*
> +	 * Wait for offset cancellation to complete.
> +	 * Since this takes a while, do not slam the i2c.
> +	 * The least amount of time is not known, but measurement showed, that
> +	 * the cancelation usually finishes 20 - 28 ms, when
> +	 * TWL4030_OFFSET_CNCL_SEL == 1.
> +	 * Start polling the status after 10ms.
> +	 */
> +	usleep_range(10000, 11000);
>  	do {
>  		/* this takes a little while, so don't slam i2c */

I'll resend, and remove this comment, since it is not needed anymore...

> -		udelay(2000);
> +		usleep_range(1000, 2000);
>  		twl_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE, &byte,
>  				    TWL4030_REG_ANAMICL);
>  	} while ((i++ < 100) &&


-- 
Péter