From: Greg KH <gregkh@suse.de>
To: Jack Stone <jwjstone@fastmail.fm>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
Florian Fainelli <florian@openwrt.org>,
stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
600155@bugs.debian.org, Jason Heeris <jason.heeris@gmail.com>,
David Miller <davem@davemloft.net>,
spamalot@hispeed.ch, Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [11/17] r6040: Fix multicast list iteration when hash filter is used
Date: Fri, 22 Oct 2010 12:23:50 -0700 [thread overview]
Message-ID: <20101022192350.GA10673@suse.de> (raw)
In-Reply-To: <4CC1E257.4070704@fastmail.fm>
On Fri, Oct 22, 2010 at 08:13:27PM +0100, Jack Stone wrote:
> On 22/10/2010 19:39, Greg KH wrote:
> > drivers/net/r6040.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- a/drivers/net/r6040.c
> > +++ b/drivers/net/r6040.c
> > @@ -976,6 +976,7 @@ static void r6040_multicast_list(struct
> > iowrite16(hash_table[3], ioaddr + MAR3);
> > }
> > /* Multicast Address 1~4 case */
> > + dmi = dev->mc_list;
> > for (i = 0, dmi; (i < dev->mc_count) && (i < MCAST_MAX); i++) {
> Any reason for the dmi in the above line? As far as I can see it is a
> nop.
Look closer at the for loop please.
thanks,
greg k-h
next prev parent reply other threads:[~2010-10-22 19:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 18:40 [00/17] 2.6.27.55-stable review Greg KH
2010-10-22 18:39 ` [01/17] aio: check for multiplication overflow in do_io_submit Greg KH
2010-10-22 18:39 ` [02/17] guard page for stacks that grow upwards Greg KH
2010-10-22 18:39 ` [03/17] ALSA: sound/pci/rme9652: prevent reading uninitialized stack memory Greg KH
2010-10-22 18:39 ` [04/17] ALSA: prevent heap corruption in snd_ctl_new() Greg KH
2010-10-22 18:39 ` [05/17] v4l1: fix 32-bit compat microcode loading translation Greg KH
2010-10-22 18:39 ` [06/17] dmaengine: fix interrupt clearing for mv_xor Greg KH
2010-10-22 18:39 ` [07/17] wext: fix potential private ioctl memory content leak Greg KH
2010-10-22 18:39 ` [08/17] atl1: fix resume Greg KH
2010-10-22 18:39 ` [09/17] [SCSI] bsg: fix incorrect device_status value Greg KH
2010-10-22 18:39 ` [10/17] r6040: fix r6040_multicast_list Greg KH
2010-10-22 18:39 ` [11/17] r6040: Fix multicast list iteration when hash filter is used Greg KH
2010-10-22 19:13 ` Jack Stone
2010-10-22 19:23 ` Greg KH [this message]
2010-10-22 19:29 ` Jack Stone
2010-10-22 21:18 ` Ben Hutchings
2010-10-22 21:23 ` Jack Stone
2010-10-22 18:39 ` [12/17] powerpc: Initialise paca->kstack before early_setup_secondary Greg KH
2010-10-22 18:39 ` [13/17] powerpc: Dont use kernel stack with translation off Greg KH
2010-10-22 18:39 ` [14/17] b44: fix carrier detection on bind Greg KH
2010-10-22 18:39 ` [15/17] setup_arg_pages: diagnose excessive argument size Greg KH
2010-10-22 18:39 ` [16/17] execve: improve interactivity with large arguments Greg KH
2010-10-22 18:39 ` [17/17] execve: make responsive to SIGKILL " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022192350.GA10673@suse.de \
--to=gregkh@suse.de \
--cc=600155@bugs.debian.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=jason.heeris@gmail.com \
--cc=jwjstone@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=spamalot@hispeed.ch \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.