From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable
Date: Fri, 22 Oct 2010 15:36:47 -0600 [thread overview]
Message-ID: <20101022213647.GD30241@obsidianresearch.com> (raw)
In-Reply-To: <35AAF1E4A771E142979F27B51793A488873ABE076D-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
On Fri, Oct 22, 2010 at 02:28:54PM -0700, Ralph Campbell wrote:
> I'm not sure this is the right change. I agree there are a lot of
> clean up on error bugs. pci_set_consistent_dma_mask() isn't optional
> because the chip doesn't support 32-bit PCIe addressing.
Do you think pci_enable_pcie_error_reporting is optional? My test
machine doesn't have a chipset with AER so that will always fail (or
something), the driver hasn't exploded yet ... :)
> I'll look it over and try to come up with something better.
>
> I'll submit a patch for the CONFIG_PCI_MSI not set case.
The resource leaks suck too, since you have to reboot to try again.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-22 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 20:42 [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable Jason Gunthorpe
[not found] ` <20101022204245.GC30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-10-22 21:28 ` Ralph Campbell
[not found] ` <35AAF1E4A771E142979F27B51793A488873ABE076D-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-10-22 21:36 ` Jason Gunthorpe [this message]
[not found] ` <20101022213647.GD30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-10-22 21:39 ` Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022213647.GD30241@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.