From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Renninger <trenn@suse.de>
Cc: Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI: Make Embedded Controller command timeout delay configurable
Date: Sat, 23 Oct 2010 01:43:24 +0200 [thread overview]
Message-ID: <201010230143.24858.rjw@sisk.pl> (raw)
In-Reply-To: <201010230046.06637.trenn@suse.de>
On Saturday, October 23, 2010, Thomas Renninger wrote:
> On Friday 22 October 2010 11:22:00 pm Rafael J. Wysocki wrote:
> > On Friday, October 22, 2010, Len Brown wrote:
> > > applied
> >
> > OK
> >
> > What if I do ec_delay=0 ?
> Same as with quite some other boot params:
> Your machine won't boot.
>
> Why should this be a problem?
Because your intention is to allow the users to _increase_ the delay and not
to decrease it. Decreasing it is known dangerous, so why don't you simply
put a limit in there?
I know there are many boot params that will hurt you if not used with care,
but is that a sufficient reason for adding another one?
Rafael
next prev parent reply other threads:[~2010-10-22 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 16:24 [PATCH] ACPI: Make Embedded Controller command timeout delay configurable Thomas Renninger
2010-10-21 19:53 ` Rafael J. Wysocki
2010-10-22 5:25 ` Len Brown
2010-10-22 5:22 ` Len Brown
2010-10-22 21:22 ` Rafael J. Wysocki
2010-10-22 22:46 ` Thomas Renninger
2010-10-22 23:43 ` Rafael J. Wysocki [this message]
2010-10-24 22:34 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010230143.24858.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.