From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxafb: correct the vertical back porch macro
Date: Sat, 23 Oct 2010 16:18:38 +0200 [thread overview]
Message-ID: <201010231618.39191.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTinb3hNdp5evit9Ga0Z-gLCfPrPzE1VdCvwQVB3o@mail.gmail.com>
Dne So 23. ??jna 2010 03:07:34 Eric Miao napsal(a):
> On Sat, Oct 23, 2010 at 5:26 AM, Matt Reimer <mreimer@sdgsystems.com> wrote:
> > Fix an off-by-one bug in the LCCR2_BegFrmDel() macro. The vertical back
> > porch knob LCCR2[BFW] specifies the number of clock periods minus one,
> > but the macro wasn't doing the subtraction.
> > ---
> > arch/arm/mach-pxa/include/mach/regs-lcd.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-pxa/include/mach/regs-lcd.h
> > b/arch/arm/mach-pxa/include/mach/regs-lcd.h index f82dcea..5074d18
> > 100644
> > --- a/arch/arm/mach-pxa/include/mach/regs-lcd.h
> > +++ b/arch/arm/mach-pxa/include/mach/regs-lcd.h
> > @@ -107,7 +107,7 @@
> > #define LCCR2_EndFrmDel(Tln) ((Tln) << FShft (LCCR2_EFW))
> >
> > #define LCCR2_BFW Fld (8, 24) /* Beginning-of-Frame line clock
> > */ -#define LCCR2_BegFrmDel(Tln) ((Tln) << FShft (LCCR2_BFW))
> > +#define LCCR2_BegFrmDel(Tln) (((Tln) - 1) << FShft (LCCR2_BFW))
>
> Nothing in the spec suggests that this minus 1 is necessary. Could you
> please double check?
It doesn't fit the settings in U-Boot or something ... it's a long known thing. I
remember in U-Boot, one had to actually subtract one in the LCD configuration
data structure so it'd be programmer correctly.
>
> > #define LCCR3_API (0xf << 16) /* AC Bias pin trasitions per
> > interrupt */ #define LCCR3_API_S 16
> > --
> > 1.7.0.4
> >
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2010-10-23 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 21:26 [PATCH] pxafb: correct the vertical back porch macro Matt Reimer
2010-10-23 1:07 ` Eric Miao
2010-10-23 14:18 ` Marek Vasut [this message]
2010-10-25 13:26 ` Matt Reimer
2010-10-24 8:29 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010231618.39191.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.