From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC 3/12] ib-mgmt: add SA MAD definitions to umad Date: Sat, 23 Oct 2010 13:08:41 -0600 Message-ID: <20101023190841.GB10883@obsidianresearch.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sasha Khapyorsky , Hal Rosenstock , Ira Weiny List-Id: linux-rdma@vger.kernel.org On Sat, Oct 23, 2010 at 12:02:11AM -0700, Hefty, Sean wrote: > +struct umad_sa_packet { > + struct umad_hdr mad_hdr; > + struct umad_rmpp_hdr rmpp_hdr; > + uint8_t sm_key[8]; I would like to see a umad64_ne_t type for these 64 bit quanties. It can be 2 32 bit words inside, and hton64xx varients to read/write them. Ditto for 128 bit quantities, and accessors to/from ibv_gid_t. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html