From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv10 12/12] mlx4: Add vlan support to IBoE
Date: Sun, 24 Oct 2010 09:10:50 +0200 [thread overview]
Message-ID: <20101024071050.GF6367@mtldesk30> (raw)
In-Reply-To: <ada7hh9x6mg.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
On Fri, Oct 22, 2010 at 02:25:11PM -0700, Roland Dreier wrote:
> > @@ -1801,6 +1831,11 @@ int mlx4_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
> > ctrl->owner_opcode = mlx4_ib_opcode[wr->opcode] |
> > (ind & qp->sq.wqe_cnt ? cpu_to_be32(1 << 31) : 0) | blh;
> >
> > + if (vlan < 0x1000) {
> > + ctrl->ins_vlan = 1 << 6;
> > + ctrl->vlan_tag = vlan;
> > + }
>
> Looks like a bug here -- vlan is __be16 and holds the vlan tag in
> network order. So this should be a test of be16_to_cpu(vlan) < 0x1000, right?
>
Sure, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-10-24 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 14:19 [PATCHv10 12/12] mlx4: Add vlan support to IBoE Eli Cohen
2010-10-22 21:25 ` Roland Dreier
[not found] ` <ada7hh9x6mg.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-24 7:10 ` Eli Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024071050.GF6367@mtldesk30 \
--to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.